From: Dave Korn <dave.korn.cygwin@googlemail.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: binutils@sourceware.org,
Dave Korn <dave.korn.cygwin@googlemail.com>,
Tom Tromey <tromey@redhat.com>,
gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: How to get file descriptor from abfd?
Date: Thu, 11 Jun 2009 02:14:00 -0000 [thread overview]
Message-ID: <4A306B61.7030205@gmail.com> (raw)
In-Reply-To: <8ac60eac0906101009r831248ej4638bb0cf12b8305@mail.gmail.com>
Paul Pluzhnikov wrote:
> The braces introduce a new scope for 'FILE *f'.
> If I move the declaration to the top of function, then it fails to build
> when !HAVE_MMAP:
>
> cc1: warnings being treated as errors
> ../../src/bfd/cache.c: In function 'cache_bmmap':
> ../../src/bfd/cache.c:404: warning: unused variable 'f'
>
> I left this "as is".
Yes, of course you are correct here; I forgot the complication of the #if
relating to whether the variable was needed or not.
cheers,
DaveK
next prev parent reply other threads:[~2009-06-11 2:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-31 17:56 Paul Pluzhnikov
2009-05-31 18:12 ` Dave Korn
2009-06-02 5:55 ` Paul Pluzhnikov
2009-06-08 16:10 ` Paul Pluzhnikov
2009-06-10 15:14 ` Dave Korn
2009-06-10 17:09 ` Paul Pluzhnikov
2009-06-10 23:59 ` Alan Modra
2009-06-11 0:42 ` Paul Pluzhnikov
2009-06-11 2:14 ` Dave Korn [this message]
2009-06-11 3:28 ` Dave Korn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A306B61.7030205@gmail.com \
--to=dave.korn.cygwin@googlemail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=ppluzhnikov@google.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox