[RFA/commit?] Add gdb to the list of supported dirs on x86_64-darwin

[RFA/commit?] Add gdb to the list of supported dirs on x86_64-darwin

[Joel Brobecker]

[-- Attachment #1: Type: text/plain, Size: 794 bytes --]

Hello,

I found this patch from Tristan Gingold from one of our source trees...
It's one of two very small patches that allow us to build GDB on
x86_64-darwin (right now, we only support x86-darwin), so I thought
I'd contribute it.

I'm not exactly clear who has jurisdiction over this type of change.
This file is in the root directory.  If I understand the MAINTAINERS
file correctly, it looks like any Global Maintainer from either GCC,
or Binutils, or GDB, etc, can approve it? (I'm GM for GDB)

2009-03-16  Tristan Gingold  <gingold@adacore.com>

        * configure.ac: Treat gdb as supported on x86_64-darwin.
        * configure: Regenerate.

Tested on x86_64-darwin by building the debugger. GDB is missing
another configure patch, but I'll commit it shortly.

OK to checkin?
-- 
Joel

[-- Attachment #2: src.diff --]
[-- Type: text/x-diff, Size: 1536 bytes --]

Index: configure.ac
===================================================================
RCS file: /cvs/src/src/configure.ac,v
retrieving revision 1.59
diff -u -p -r1.59 configure.ac
--- configure.ac	16 Mar 2009 13:29:49 -0000	1.59
+++ configure.ac	16 Mar 2009 14:49:26 -0000
@@ -446,11 +446,11 @@ case "${target}" in
   *-*-chorusos)
     noconfigdirs="$noconfigdirs target-newlib target-libgloss ${libgcj}"
     ;;
-  powerpc-*-darwin* | x86_64-*-darwin[[912]]*)
+  powerpc-*-darwin*)
     noconfigdirs="$noconfigdirs ld gas gdb gprof"
     noconfigdirs="$noconfigdirs sim target-rda"
     ;;
-  i[[3456789]]86-*-darwin*)
+  i[[3456789]]86-*-darwin* | x86_64-*-darwin9*)
     noconfigdirs="$noconfigdirs ld gas gprof"
     noconfigdirs="$noconfigdirs sim target-rda"
     ;;
Index: configure
===================================================================
RCS file: /cvs/src/src/configure,v
retrieving revision 1.313
diff -u -p -r1.313 configure
--- configure	16 Mar 2009 13:29:49 -0000	1.313
+++ configure	16 Mar 2009 14:49:28 -0000
@@ -2211,11 +2211,11 @@ case "${target}" in
   *-*-chorusos)
     noconfigdirs="$noconfigdirs target-newlib target-libgloss ${libgcj}"
     ;;
-  powerpc-*-darwin* | x86_64-*-darwin[912]*)
+  powerpc-*-darwin*)
     noconfigdirs="$noconfigdirs ld gas gdb gprof"
     noconfigdirs="$noconfigdirs sim target-rda"
     ;;
-  i[3456789]86-*-darwin*)
+  i[3456789]86-*-darwin* | x86_64-*-darwin9*)
     noconfigdirs="$noconfigdirs ld gas gprof"
     noconfigdirs="$noconfigdirs sim target-rda"
     ;;

Re: [RFA/commit?] Add gdb to the list of supported dirs on x86_64-darwin

[Paolo Bonzini]

Joel Brobecker wrote:
> Hello,
> 
> I found this patch from Tristan Gingold from one of our source trees...
> It's one of two very small patches that allow us to build GDB on
> x86_64-darwin (right now, we only support x86-darwin), so I thought
> I'd contribute it.
> 
> I'm not exactly clear who has jurisdiction over this type of change.
> This file is in the root directory.  If I understand the MAINTAINERS
> file correctly, it looks like any Global Maintainer from either GCC,
> or Binutils, or GDB, etc, can approve it? (I'm GM for GDB)

It clearly affects only gdb.  Go ahead, but please commit it to the gcc
repository too.

Paolo

Re: [RFA/commit?] Add gdb to the list of supported dirs on x86_64-darwin

[Joel Brobecker]

> It clearly affects only gdb.  Go ahead, but please commit it to the gcc
> repository too.

Thank you. I checked in the patch in both repositories.

-- 
Joel