Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@palves.net>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdbserver: handle running threads in qXfer:threads:read
Date: Wed, 22 Jul 2020 12:46:34 +0100	[thread overview]
Message-ID: <4973c5c0-f21b-de84-9ca8-37ec326f28db@palves.net> (raw)
In-Reply-To: <20200721211510.70c99462@f32-m1.lan>

On 7/22/20 5:15 AM, Kevin Buettner wrote:
> On Wed, 22 Jul 2020 02:43:24 +0100
> Pedro Alves <pedro@palves.net> wrote:
> 
>> On some systems, the gdb.multi/multi-target.exp testcase occasionally
>> fails...
> 
> I've applied your patch on my local machines and have run the
> following command repeatedly on builds on F28, F31, F32, and Rawhide:
> 
> make check RUNTESTFLAGS="--target_board unix" TESTS="gdb.multi/multi-target.exp"
> 
> Each test run on all four machines reports:
> 
> # of expected passes		486
> 
> To put this in context, I never saw that result on the machines in
> question without your patch.  Without your patch, there were *always*
> unexpected failures and untested testcases and, moreover, the numbers
> reported would frequently vary from one run to the next.
> 
> So, a definite (and very welcome) improvement!

Great!  I've merged the fix with Tankut's comments addressed.

Thanks,
Pedro Alves



  reply	other threads:[~2020-07-22 11:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-22  1:43 Pedro Alves
2020-07-22  4:15 ` Kevin Buettner
2020-07-22 11:46   ` Pedro Alves [this message]
2020-07-22  7:32 ` Aktemur, Tankut Baris
2020-07-22 11:36   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4973c5c0-f21b-de84-9ca8-37ec326f28db@palves.net \
    --to=pedro@palves.net \
    --cc=gdb-patches@sourceware.org \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox