From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by sourceware.org (Postfix) with ESMTPS id 8075D382E05B for ; Wed, 22 Jul 2020 11:46:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8075D382E05B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wm1-f68.google.com with SMTP id j18so1645419wmi.3 for ; Wed, 22 Jul 2020 04:46:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WCeh8hlHHJQoiCtTER0dOLNZT10psFv9al1AssWFwCQ=; b=KUQYNalZEa2kMmY/1LuR5DwWohFdG3HAR/Q2YiIgPnWYvqm8avzcD8/LGP+rFRfup4 8NbR0O+hZ4AYfW8fqi0quYOBVEplrJ1SixNqsJlU6tRm6fgKJYYu2/vaTavQ4nH+cieH lsq8slX/kTt1mUIA9GKka1lMOjXq7s6L1OTlVawaZhwlO2Ych3P3/j5fpdhik9stmSVl b4IPuv/NbKEkR+VzglBpgiRHxlBCMkvxRAkn/64ulUCrsjed59XlamBHK2W6P30SPjQN KIZEpmE3E7LpzAefAQUU4zBrRbIwsd5q/4W78bgzMdbCDQ3DTlKB3LPLQeUPYm0h7ycm /erg== X-Gm-Message-State: AOAM531pZgbPqzmPJNHEhsgObu2J2CPk4mYmZeEaMZXy4hmNUDuiNNmE rutXFnMCcLpC2jax36Kj8nEtTce2qSU= X-Google-Smtp-Source: ABdhPJzkX99Ran8kCK3faYX8/ZTYx/OcHj3GcZac8+PCCui69oza/oHapZ6IIg3+Lf6z3rph29TAUA== X-Received: by 2002:a1c:7d55:: with SMTP id y82mr7985835wmc.72.1595418396541; Wed, 22 Jul 2020 04:46:36 -0700 (PDT) Received: from ?IPv6:2001:8a0:f91a:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f91a:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id l15sm39850883wro.33.2020.07.22.04.46.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Jul 2020 04:46:35 -0700 (PDT) Subject: Re: [PATCH] gdbserver: handle running threads in qXfer:threads:read To: Kevin Buettner References: <20200722014324.23166-1-pedro@palves.net> <20200721211510.70c99462@f32-m1.lan> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <4973c5c0-f21b-de84-9ca8-37ec326f28db@palves.net> Date: Wed, 22 Jul 2020 12:46:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200721211510.70c99462@f32-m1.lan> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2020 11:46:40 -0000 On 7/22/20 5:15 AM, Kevin Buettner wrote: > On Wed, 22 Jul 2020 02:43:24 +0100 > Pedro Alves wrote: > >> On some systems, the gdb.multi/multi-target.exp testcase occasionally >> fails... > > I've applied your patch on my local machines and have run the > following command repeatedly on builds on F28, F31, F32, and Rawhide: > > make check RUNTESTFLAGS="--target_board unix" TESTS="gdb.multi/multi-target.exp" > > Each test run on all four machines reports: > > # of expected passes 486 > > To put this in context, I never saw that result on the machines in > question without your patch. Without your patch, there were *always* > unexpected failures and untested testcases and, moreover, the numbers > reported would frequently vary from one run to the next. > > So, a definite (and very welcome) improvement! Great! I've merged the fix with Tankut's comments addressed. Thanks, Pedro Alves