Re: [PATCH] gdbserver: handle running threads in qXfer:threads:read

[Pedro Alves <pedro@palves.net>]

On 7/22/20 8:32 AM, Aktemur, Tankut Baris wrote:
> On Wednesday, July 22, 2020 3:43 AM, Pedro Alves wrote:
>> diff --git a/gdbserver/inferiors.cc b/gdbserver/inferiors.cc
>> index 88adb16eac2..0bdf4b761e8 100644
>> --- a/gdbserver/inferiors.cc
>> +++ b/gdbserver/inferiors.cc
>> @@ -223,6 +223,16 @@ switch_to_thread (process_stratum_target *ops, ptid_t ptid)
>>    current_thread = find_thread_ptid (ptid);
>>  }
>>
>> +/* See inferiors.h.  */
>> +
>> +void
>> +switch_to_process (struct process_info *proc)
> 
> Can we get rid of 'struct' here?

Done.

> 
>> +{
>> +  int pid = pid_of (proc);
>> +
>> +  current_thread = find_any_thread_of_pid (pid);
>> +}
>> +
>>  /* See gdbsupport/common-inferior.h.  */
>>
>>  const char *
>> diff --git a/gdbserver/inferiors.h b/gdbserver/inferiors.h
>> index 4e24b2c7bb2..2af0169a4e1 100644
>> --- a/gdbserver/inferiors.h
>> +++ b/gdbserver/inferiors.h
>> @@ -138,6 +138,9 @@ struct process_info *find_process_pid (int pid);
>>  int have_started_inferiors_p (void);
>>  int have_attached_inferiors_p (void);
>>
>> +/* Switch to a thread of PROC.  */
>> +void switch_to_process (struct process_info *proc);
> 
> And here.

Done.

> 
>> +
>>  void clear_inferiors (void);
>>
>>  void *thread_target_data (struct thread_info *);
>> diff --git a/gdbserver/server.cc b/gdbserver/server.cc
>> index ab5363eb032..b1015229ad0 100644
>> --- a/gdbserver/server.cc
>> +++ b/gdbserver/server.cc
>> @@ -48,6 +48,7 @@
>>  #include "gdbsupport/selftest.h"
>>  #include "gdbsupport/scope-exit.h"
>>  #include "gdbsupport/gdb_select.h"
>> +#include "gdbsupport/scoped_restore.h"
>>
>>  #define require_running_or_return(BUF)		\
>>    if (!target_running ())			\
>> @@ -1678,19 +1679,54 @@ handle_qxfer_threads_worker (thread_info *thread, struct buffer
>> *buffer)
>>    buffer_xml_printf (buffer, "/>\n");
>>  }
>>
>> -/* Helper for handle_qxfer_threads.  */
>> +/* Helper for handle_qxfer_threads.  Return true on success, false
>> +   otherwise.  */
>>
>> -static void
>> +static bool
>>  handle_qxfer_threads_proper (struct buffer *buffer)
>>  {
>> +  client_state &cs = get_client_state ();
>> +
>> +  scoped_restore save_current_thread
>> +    = make_scoped_restore (&current_thread);
>> +  scoped_restore save_current_generalte_thread
> 
> "generalte" seems like a typo.

Indeed it is.

Thanks for taking a look.  I've merged the patch with those
fixes now.

Pedro Alves