From: Michael Snyder <msnyder@vmware.com>
To: Doug Evans <dje@google.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] Improve comment in linux-low.c:handle_extended_wait
Date: Thu, 18 Dec 2008 19:19:00 -0000 [thread overview]
Message-ID: <494AA0DF.8040902@vmware.com> (raw)
In-Reply-To: <20081213213041.D19D51C7A0F@localhost>
Looks fine.
Doug Evans wrote:
> Hi.
>
> This is a minor cleanup to a comment.
> What "it" is isn't clear.
>
> Ok to check in?
>
> 2008-12-13 Doug Evans <dje@google.com>
>
> * linux-low.c (handle_extended_wait): Improve comment.
>
> Index: linux-low.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbserver/linux-low.c,v
> retrieving revision 1.84
> diff -u -p -r1.84 linux-low.c
> --- linux-low.c 12 Dec 2008 23:14:28 -0000 1.84
> +++ linux-low.c 13 Dec 2008 21:28:12 -0000
> @@ -180,7 +180,8 @@ handle_extended_wait (struct process_inf
>
> /* Normally we will get the pending SIGSTOP. But in some cases
> we might get another signal delivered to the group first.
> - If we do, be sure not to lose it. */
> + If we do get another signal, be sure not to lose the SIGSTOP:
> + when we later get it we'll want to resume. */
> if (WSTOPSIG (status) == SIGSTOP)
> {
> if (stopping_threads)
next prev parent reply other threads:[~2008-12-18 19:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-13 21:31 Doug Evans
2008-12-18 19:19 ` Michael Snyder [this message]
2008-12-18 19:25 ` Daniel Jacobowitz
2009-01-06 0:24 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494AA0DF.8040902@vmware.com \
--to=msnyder@vmware.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox