Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: gdb-patches@sourceware.org, Michael Snyder <msnyder@vmware.com>
Subject: Re: [RFA] Improve comment in linux-low.c:handle_extended_wait
Date: Tue, 06 Jan 2009 00:24:00 -0000	[thread overview]
Message-ID: <e394668d0901051624r26f16c15x72278e795d2676cf@mail.gmail.com> (raw)
In-Reply-To: <20081218192447.GA29775@caradoc.them.org>

On Thu, Dec 18, 2008 at 11:24 AM, Daniel Jacobowitz <drow@false.org> wrote:
> On Sat, Dec 13, 2008 at 01:30:41PM -0800, Doug Evans wrote:
>> Hi.
>>
>> This is a minor cleanup to a comment.
>> What "it" is isn't clear.
>>
>> Ok to check in?
>
> Actually, I meant "be sure not to lose the other signal".  We
> previously would just stop and think we'd gotten the SIGSTOP.
> But your version is equally valid.

I checked in this version.

2008-12-13  Doug Evans  <dje@google.com>

        * linux-low.c (handle_extended_wait): Improve comment.

Index: linux-low.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/linux-low.c,v
retrieving revision 1.87
diff -u -p -r1.87 linux-low.c
--- linux-low.c 5 Jan 2009 23:11:48 -0000       1.87
+++ linux-low.c 6 Jan 2009 00:14:03 -0000
@@ -180,7 +180,7 @@ handle_extended_wait (struct process_inf

       /* Normally we will get the pending SIGSTOP.  But in some cases
         we might get another signal delivered to the group first.
-         If we do, be sure not to lose it.  */
+        If we do get another signal, be sure not to lose it.  */
       if (WSTOPSIG (status) == SIGSTOP)
        {
          if (stopping_threads)


      reply	other threads:[~2009-01-06  0:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-13 21:31 Doug Evans
2008-12-18 19:19 ` Michael Snyder
2008-12-18 19:25 ` Daniel Jacobowitz
2009-01-06  0:24   ` Doug Evans [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e394668d0901051624r26f16c15x72278e795d2676cf@mail.gmail.com \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox