Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Stan Shebs <stan@codesourcery.com>
To: Stan Shebs <stan@codesourcery.com>,
	  Tristan Gingold <gingold@adacore.com>,
	 gdb-patches@sourceware.org
Subject: Re: [RFA] Darwin/x86 port (v4 - part 1/4: machoread.c)
Date: Tue, 18 Nov 2008 21:46:00 -0000	[thread overview]
Message-ID: <49230DBA.1030208@codesourcery.com> (raw)
In-Reply-To: <20081118033551.GB18294@caradoc.them.org>

Daniel Jacobowitz wrote:
> On Mon, Nov 17, 2008 at 05:31:21PM -0800, Stan Shebs wrote:
>   
>>> DEF_VEC_O(oso_el);
>>> static VEC(oso_el) *oso_vector;
>>>       
>> The vector macros should follow the "space before paren" just as  
>> everybody else does, although I note that the doc in vec.h confuses  
>> things by not following the general rule.
>>     
>
> FWIW, I decided to skip this space when writing other code using VEC.
> I put it in after VEC_index, but not VEC.  It made things much simpler
> to read.  But it's not strictly proper, so either way is fine with me.
>   
The whole space-or-no-space issue is so pedantic I can barely type this 
message :-) , but the reality is that if you complicate the rules to 
allow some exceptions, it opens the door to interminable debates over 
whether this or that construct is exception-worthy. We minimize the time 
we spend thinking about this by just having the one simple rule that 
mechanically applies to everything.

Stan


  reply	other threads:[~2008-11-18 18:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-14 18:33 Tristan Gingold
2008-11-18 17:20 ` Stan Shebs
2008-11-18 19:54   ` Daniel Jacobowitz
2008-11-18 21:46     ` Stan Shebs [this message]
2008-11-18 21:50       ` Daniel Jacobowitz
2008-11-19 21:21   ` Tristan Gingold
2008-11-26 16:30     ` Stan Shebs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49230DBA.1030208@codesourcery.com \
    --to=stan@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=gingold@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox