From: Daniel Jacobowitz <drow@false.org>
To: Stan Shebs <stan@codesourcery.com>
Cc: Tristan Gingold <gingold@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Darwin/x86 port (v4 - part 1/4: machoread.c)
Date: Tue, 18 Nov 2008 19:54:00 -0000 [thread overview]
Message-ID: <20081118033551.GB18294@caradoc.them.org> (raw)
In-Reply-To: <49221AE9.5050600@codesourcery.com>
On Mon, Nov 17, 2008 at 05:31:21PM -0800, Stan Shebs wrote:
>> DEF_VEC_O(oso_el);
>> static VEC(oso_el) *oso_vector;
> The vector macros should follow the "space before paren" just as
> everybody else does, although I note that the doc in vec.h confuses
> things by not following the general rule.
FWIW, I decided to skip this space when writing other code using VEC.
I put it in after VEC_index, but not VEC. It made things much simpler
to read. But it's not strictly proper, so either way is fine with me.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-11-18 3:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-14 18:33 Tristan Gingold
2008-11-18 17:20 ` Stan Shebs
2008-11-18 19:54 ` Daniel Jacobowitz [this message]
2008-11-18 21:46 ` Stan Shebs
2008-11-18 21:50 ` Daniel Jacobowitz
2008-11-19 21:21 ` Tristan Gingold
2008-11-26 16:30 ` Stan Shebs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081118033551.GB18294@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=gingold@adacore.com \
--cc=stan@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox