From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8844 invoked by alias); 18 Nov 2008 03:36:34 -0000 Received: (qmail 8808 invoked by uid 22791); 18 Nov 2008 03:36:34 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 18 Nov 2008 03:35:54 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 8AC5710DB0; Tue, 18 Nov 2008 03:35:52 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 2844810D50; Tue, 18 Nov 2008 03:35:52 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1L2HNX-00050u-2Q; Mon, 17 Nov 2008 22:35:51 -0500 Date: Tue, 18 Nov 2008 19:54:00 -0000 From: Daniel Jacobowitz To: Stan Shebs Cc: Tristan Gingold , gdb-patches@sourceware.org Subject: Re: [RFA] Darwin/x86 port (v4 - part 1/4: machoread.c) Message-ID: <20081118033551.GB18294@caradoc.them.org> Mail-Followup-To: Stan Shebs , Tristan Gingold , gdb-patches@sourceware.org References: <7B1402FF-6CAB-4C6A-AAB5-81E062080FB5@adacore.com> <49221AE9.5050600@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49221AE9.5050600@codesourcery.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00461.txt.bz2 On Mon, Nov 17, 2008 at 05:31:21PM -0800, Stan Shebs wrote: >> DEF_VEC_O(oso_el); >> static VEC(oso_el) *oso_vector; > The vector macros should follow the "space before paren" just as > everybody else does, although I note that the doc in vec.h confuses > things by not following the general rule. FWIW, I decided to skip this space when writing other code using VEC. I put it in after VEC_index, but not VEC. It made things much simpler to read. But it's not strictly proper, so either way is fine with me. -- Daniel Jacobowitz CodeSourcery