From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1508 invoked by alias); 18 Nov 2008 18:48:05 -0000 Received: (qmail 1462 invoked by uid 22791); 18 Nov 2008 18:48:05 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 18 Nov 2008 18:47:30 +0000 Received: (qmail 31574 invoked from network); 18 Nov 2008 18:47:28 -0000 Received: from unknown (HELO macbook-2.local) (stan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 18 Nov 2008 18:47:28 -0000 Message-ID: <49230DBA.1030208@codesourcery.com> Date: Tue, 18 Nov 2008 21:46:00 -0000 From: Stan Shebs User-Agent: Thunderbird 2.0.0.17 (Macintosh/20080914) MIME-Version: 1.0 To: Stan Shebs , Tristan Gingold , gdb-patches@sourceware.org Subject: Re: [RFA] Darwin/x86 port (v4 - part 1/4: machoread.c) References: <7B1402FF-6CAB-4C6A-AAB5-81E062080FB5@adacore.com> <49221AE9.5050600@codesourcery.com> <20081118033551.GB18294@caradoc.them.org> In-Reply-To: <20081118033551.GB18294@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00473.txt.bz2 Daniel Jacobowitz wrote: > On Mon, Nov 17, 2008 at 05:31:21PM -0800, Stan Shebs wrote: > >>> DEF_VEC_O(oso_el); >>> static VEC(oso_el) *oso_vector; >>> >> The vector macros should follow the "space before paren" just as >> everybody else does, although I note that the doc in vec.h confuses >> things by not following the general rule. >> > > FWIW, I decided to skip this space when writing other code using VEC. > I put it in after VEC_index, but not VEC. It made things much simpler > to read. But it's not strictly proper, so either way is fine with me. > The whole space-or-no-space issue is so pedantic I can barely type this message :-) , but the reality is that if you complicate the rules to allow some exceptions, it opens the door to interminable debates over whether this or that construct is exception-worthy. We minimize the time we spend thinking about this by just having the one simple rule that mechanically applies to everything. Stan