From: Phil Muldoon <pmuldoon@redhat.com>
To: "Sérgio Durigan Júnior" <sergiodj@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 4/4] 'catch syscall' feature -- Build system, documentation and testcase
Date: Tue, 04 Nov 2008 08:19:00 -0000 [thread overview]
Message-ID: <49100551.6010000@redhat.com> (raw)
In-Reply-To: <1225773088.24532.56.camel@miki>
Sérgio Durigan Júnior wrote:
> This last part modifies the build system (in order to implement the
> GDB's datadir), adds the documentation and the testcase for the new
> feature.
>
Nice, looks great! Just some comments on tests.
This is a forward of a comment from the archer list on the original
patch-set. On targets that do support syscall breakpoints, but there is
no xml database (like on x8664) will these tests just fail? Are they
gated to XFAIL (or however one would gracefully fail here).
My only other comment is how this would work on remote targets (i.e.
remote target is x86, but your host is PPC).
Regards
Phil Muldoon
next prev parent reply other threads:[~2008-11-04 8:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 4:32 Sérgio Durigan Júnior
2008-11-04 8:19 ` Phil Muldoon [this message]
2008-11-04 15:03 ` Sérgio Durigan Júnior
2008-11-04 15:16 ` Daniel Jacobowitz
2008-11-04 15:36 ` Sérgio Durigan Júnior
2008-11-04 15:50 ` Daniel Jacobowitz
2008-11-04 16:33 ` Tom Tromey
2008-11-07 4:03 ` Sérgio Durigan Júnior
2008-11-04 20:03 ` Pedro Alves
2008-11-04 20:33 ` Sérgio Durigan Júnior
2008-11-04 20:47 ` Pedro Alves
2008-11-04 20:54 ` Eli Zaretskii
2008-11-07 3:58 ` Sérgio Durigan Júnior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49100551.6010000@redhat.com \
--to=pmuldoon@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox