Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: "Sérgio Durigan Júnior" <sergiodj@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 4/4] 'catch syscall' feature -- Build system, documentation 	and testcase
Date: Tue, 04 Nov 2008 20:47:00 -0000	[thread overview]
Message-ID: <200811042047.04683.pedro@codesourcery.com> (raw)
In-Reply-To: <1225830755.32321.28.camel@miki>

On Tuesday 04 November 2008 20:32:35, Sérgio Durigan Júnior wrote:
> I just haven't spelled out because those files (configure, config.in)
> are not included in the patch. Should I mention them anyway?

Yep.  It helps us make sure the right pieces will be
regenerated; and help the ones that want to try the patch to know
which files they need to regenerate, and you'll have to spell them out
anyway at commit time.  :-)

(personally, if regenerated changes are small-ish, I don't mind if
they're included in the patch, since it makes it easier to
try the patches out (bandwidth is cheaper nowadays), and confirm the
submitter is using the correct autotools version.  But, that's not
established practice, and I'm a newbie here  :-).  In fact, not
including them is recommended in gdb/CONTRIBUTE.)

-- 
Pedro Alves


  reply	other threads:[~2008-11-04 20:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-04  4:32 Sérgio Durigan Júnior
2008-11-04  8:19 ` Phil Muldoon
2008-11-04 15:03   ` Sérgio Durigan Júnior
2008-11-04 15:16     ` Daniel Jacobowitz
2008-11-04 15:36       ` Sérgio Durigan Júnior
2008-11-04 15:50         ` Daniel Jacobowitz
2008-11-04 16:33 ` Tom Tromey
2008-11-07  4:03   ` Sérgio Durigan Júnior
2008-11-04 20:03 ` Pedro Alves
2008-11-04 20:33   ` Sérgio Durigan Júnior
2008-11-04 20:47     ` Pedro Alves [this message]
2008-11-04 20:54 ` Eli Zaretskii
2008-11-07  3:58   ` Sérgio Durigan Júnior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811042047.04683.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sergiodj@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox