From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11046 invoked by alias); 4 Nov 2008 20:47:48 -0000 Received: (qmail 10977 invoked by uid 22791); 4 Nov 2008 20:47:48 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 04 Nov 2008 20:46:59 +0000 Received: (qmail 32231 invoked from network); 4 Nov 2008 20:46:57 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 4 Nov 2008 20:46:57 -0000 From: Pedro Alves To: =?iso-8859-1?q?S=E9rgio_Durigan_J=FAnior?= Subject: Re: [PATCH 4/4] 'catch syscall' feature -- Build system, documentation =?iso-8859-1?q?=09and?= testcase Date: Tue, 04 Nov 2008 20:47:00 -0000 User-Agent: KMail/1.9.10 Cc: gdb-patches@sourceware.org References: <1225773088.24532.56.camel@miki> <200811042003.02591.pedro@codesourcery.com> <1225830755.32321.28.camel@miki> In-Reply-To: <1225830755.32321.28.camel@miki> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200811042047.04683.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00048.txt.bz2 On Tuesday 04 November 2008 20:32:35, S=E9rgio Durigan J=FAnior wrote: > I just haven't spelled out because those files (configure, config.in) > are not included in the patch. Should I mention them anyway? Yep. It helps us make sure the right pieces will be regenerated; and help the ones that want to try the patch to know which files they need to regenerate, and you'll have to spell them out anyway at commit time. :-) (personally, if regenerated changes are small-ish, I don't mind if they're included in the patch, since it makes it easier to try the patches out (bandwidth is cheaper nowadays), and confirm the submitter is using the correct autotools version. But, that's not established practice, and I'm a newbie here :-). In fact, not including them is recommended in gdb/CONTRIBUTE.) --=20 Pedro Alves