From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20619 invoked by alias); 4 Nov 2008 08:19:10 -0000 Received: (qmail 20592 invoked by uid 22791); 4 Nov 2008 08:19:10 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 04 Nov 2008 08:18:31 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id mA48ISCF015651; Tue, 4 Nov 2008 03:18:28 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id mA48IRDT012404; Tue, 4 Nov 2008 03:18:27 -0500 Received: from localhost.localdomain (vpn-6-24.fab.redhat.com [10.33.6.24]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id mA48IQgj002305; Tue, 4 Nov 2008 03:18:26 -0500 Message-ID: <49100551.6010000@redhat.com> Date: Tue, 04 Nov 2008 08:19:00 -0000 From: Phil Muldoon User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: =?ISO-8859-1?Q?S=E9rgio_Durigan_J=FAnior?= CC: gdb-patches@sourceware.org Subject: Re: [PATCH 4/4] 'catch syscall' feature -- Build system, documentation and testcase References: <1225773088.24532.56.camel@miki> In-Reply-To: <1225773088.24532.56.camel@miki> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00021.txt.bz2 Sérgio Durigan Júnior wrote: > This last part modifies the build system (in order to implement the > GDB's datadir), adds the documentation and the testcase for the new > feature. > Nice, looks great! Just some comments on tests. This is a forward of a comment from the archer list on the original patch-set. On targets that do support syscall breakpoints, but there is no xml database (like on x8664) will these tests just fail? Are they gated to XFAIL (or however one would gracefully fail here). My only other comment is how this would work on remote targets (i.e. remote target is x86, but your host is PPC). Regards Phil Muldoon