Re: [PATCH 2/2] [gdb/testsuite] Use Wno-non-c-typedef-for-linkage for gcc 16

[Keith Seitz <keiths@redhat.com>]

Hi,

On 5/29/26 5:51 AM, Tom de Vries wrote:
> With gcc 16 and test-case gdb.cp/classes.exp I run into:
> ...
> classes.cc:440:15: warning: anonymous non-C-compatible type given name for linkage purposes by 'typedef' declaration [-Wnon-c-typedef-for-linkage]^M
>    440 | typedef class {^M
>        |               ^^M
>        |               DynamicBase2^M
> classes.cc:443:15: note: type is not C-compatible because it contains 'virtual int DynamicBase2::get_x()' declaration^M
>    443 |   virtual int get_x () { return x; }^M
>        |               ^~~~~^M
> ...
> 
> Fix this by applying Wno-non-c-typedef-for-linkage, which is already done for
> clang.
> 
> Likewise for gdb.cp/class2.exp.

This LGTM, just one little nit.

> diff --git a/gdb/testsuite/gdb.cp/class2.exp b/gdb/testsuite/gdb.cp/class2.exp
> index 705f51ac3e0..aa2a04467f4 100644
> --- a/gdb/testsuite/gdb.cp/class2.exp
> +++ b/gdb/testsuite/gdb.cp/class2.exp
> @@ -21,7 +21,8 @@ standard_testfile .cc
>   set flags [list debug c++]
>   # When using recent Clangs, this test fails to compile without this warning
>   # being disabled.  However, older Clangs fail to recognize the flag.

This comment could use a small update.

> -if { [gcc_major_version "clang-*" "c++"] > 10 } {
> +if { [gcc_major_version "clang-*" "c++"] > 10
> +     || [gcc_major_version "gcc-*" "c++"] >= 16} {
>       lappend flags additional_flags=-Wno-non-c-typedef-for-linkage
>   }
>   

Reviewed-By: Keith Seitz <keiths@redhat.com>

Thank you for fixing these.

Keith