Re: [PATCH 1/2] [gdb/testsuite] Fix ambiguous operator warning

[Keith Seitz <keiths@redhat.com>]

On 5/29/26 5:51 AM, Tom de Vries wrote:
> With gcc 16, defaulting to c++20, and test-case gdb.cp/cmpd-minsyms.exp I run
> into:
> ...
> cmpd-minsyms.cc: In function 'int main(int, char**)':^M
> cmpd-minsyms.cc:39:13: warning: C++20 says that these are ambiguous, even \
>    though the second is reversed:^M
>     39 |    if (a == b)^M
>        |             ^^M
> cmpd-minsyms.cc:26:8: note: candidate 1: 'int GDB<T>::operator==(const GDB<T>&) [with T = int]'^M
>     26 |    int operator == (GDB const& other)^M
>        |        ^~~~~~~~^M
> cmpd-minsyms.cc:26:8: note: candidate 2: 'int GDB<T>::operator==(const GDB<T>&) [with T = int]' (reversed)^M
> cmpd-minsyms.cc:26:8: note: try making the operator a 'const' member function^M
> ...
> 
> Fix this by following the advice:
> ...
> -   int operator == (GDB const& other)
> +   int operator == (GDB const& other) const
>      { return 1; }
> ...
> 
> Likewise in gdb.cp/many-args.exp.

This LGTM.

Reviewed-By: Keith Seitz <keiths@redhat.com>

Keith