From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gaMDFQK+GWrZQCcAWB0awg (envelope-from ) for ; Fri, 29 May 2026 12:25:38 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hFjycPkt; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 510161E062; Fri, 29 May 2026 12:25:38 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E9CCF1E062 for ; Fri, 29 May 2026 12:25:37 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8433D4BA23FE for ; Fri, 29 May 2026 16:25:37 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 582184BA2E0C for ; Fri, 29 May 2026 16:25:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 582184BA2E0C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 582184BA2E0C Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780071927; cv=none; b=F9/nTj4Ahad31Zdr7BDVBN42XHaI3kmABmaEdxAhegE543Zbh0A/BGid2AwgmAo9YgOe/Bs3Eq1VfavHxg2r5rot+yN5fxXndDxXKq7apUGCRwLMK2KV5WpXcDskAeoBcKAkDUsJRHJ5QbHL4KuX3riATPvWu/5SLOXrfCIqxTk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780071927; c=relaxed/simple; bh=TRvpz10vTw4ed5TT4RrmRoEtTg40gI2iJJI4oQvGnU8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=wbHSrbbJZlZtUoGUWtUtLXOgoB6iEPWhLMnfQhDuFAuR6TiNASBOqvv416TJACI96hTZykFy86YMa2PZNaE06Gwb/ywyoejBU0Xt9uQRrBGhAes/rMiCC09DKBWCm5bE2tvnIeNhK9abDt9BSkAFCH6GsBHSkRCwPUXlr187kqk= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hFjycPkt DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 582184BA2E0C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hFjycPkt DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780071926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nbtSK8qhry+nE3AZcnYtAW6Ho38Jij70J6tmB8969es=; b=hFjycPktdWrdgL5C8wG7PDg8O/HK5v+qDrXpyeU0aiHtEQkpn24wglBkg5JzHingXJp2sL R7KCePsB1XPudO6DGVwNOoEiDjTxvx9xeEThtKfP6xyvMzh8ZdKxLV54EGP80zJfmg6ry3 iYUh8JY0GqzG7XgOrGj9Px2K7ZNa89w= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-20-u8GyGA8hPjqozegkaonAQQ-1; Fri, 29 May 2026 12:25:25 -0400 X-MC-Unique: u8GyGA8hPjqozegkaonAQQ-1 X-Mimecast-MFC-AGG-ID: u8GyGA8hPjqozegkaonAQQ_1780071924 Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2bf1845bddfso13660305ad.1 for ; Fri, 29 May 2026 09:25:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780071924; x=1780676724; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nbtSK8qhry+nE3AZcnYtAW6Ho38Jij70J6tmB8969es=; b=SEskMCS8JsZ6om3XfByOAhyZosJr4qNqnTuQmZCFVxXwP3/NFFnXE9l9uCdgTTfTCl AQ6XYeVYDF9XBjUj2fzmNDl1JqfLEb6JQKtCI3QurOZahiyyoqRO5vwqzarN1/bHjfRk 0qNXJKgJF4ezsIw+M9KZUycv5QBuqBR7j/dkqgkoAFxHyVG/EbkjMGt6Sk/yArvVZfkK oGctNLJTOHEbNcMFJcY4SNPODjP2cLGElWCGjsN2uOAvovUr/l9A4Jf4Oxpekhv84p+o qk1MpS/hfqNgZa/24EHaVGdE2HvU6Dq2tdmEBb2x7U/P0Y0qdX/x83R2h2dukeT+xttl Uh3w== X-Forwarded-Encrypted: i=1; AFNElJ+3mF2R+UU7FQH2su9+ba5F0rm7nfWbFSS/yG8brtiEGZLm1yJRTDEiRKnMBGMcpxuc5H3dJQkxYsZbuw==@sourceware.org X-Gm-Message-State: AOJu0Yw4UqPSJTSVrTH5gJPAqVe1UH8IftXL31r+Dcni/N+7AreYX+fZ 6qX/cFPI7QRUEJD7Gvz/Hbdj/86GyQXIa+TSqYIDUuo2gVEyEBWthRtqDp4XQiodjmAx6Ddg9WF TrHgHu0C0QtT/CZtpHwjJkdLQHStG93lQYlq/s+uvbOD082953pu6ZYZD2kxyK6KrjzAr7P4= X-Gm-Gg: Acq92OFTh561mI8djAdTQaH7yt8BHm8zKHqK5MpLgS7Gv1azOUzUdPGEV408JwM+23O s9UmrwkLFtUbc/bEubN4QSpFoxHHvuwScEuh9OPnscPFc7oGOvFB2YAeZVL7Tohs+tTZimqbfq1 y29EU+NNooEZW+PJEvE8CXwrad6OIBoEcPLdLL6jZHzWIGOqWEzPqvD6dxtYhkPDIE0nNTVBGCB mxfMjo+Jn5fAOdAcIquNIi7L302UuDGfIqgWwvCHWjeTDrK6+x6sZpIVqlNzzcv/pDcOHl50W+3 /UtlxHgNzKM3i3dOWCAADk//Qyt22s9icwaQVJwbHtHMMgJospYxHZI3mFwba0HUYSg3373Wnsw qKY0qMnfZbKS7srkJbKW8WOemuajsBvDQCDeHpNk= X-Received: by 2002:a17:902:e78e:b0:2b4:5cea:f61c with SMTP id d9443c01a7336-2bf3679355bmr8395945ad.4.1780071924349; Fri, 29 May 2026 09:25:24 -0700 (PDT) X-Received: by 2002:a17:902:e78e:b0:2b4:5cea:f61c with SMTP id d9443c01a7336-2bf3679355bmr8395475ad.4.1780071923665; Fri, 29 May 2026 09:25:23 -0700 (PDT) Received: from [150.1.200.157] ([172.56.105.224]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf23c4fef9sm24554825ad.79.2026.05.29.09.25.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 May 2026 09:25:23 -0700 (PDT) Message-ID: <48defad3-5b7b-4e68-8367-1468fabaeee8@redhat.com> Date: Fri, 29 May 2026 09:25:22 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] [gdb/testsuite] Use Wno-non-c-typedef-for-linkage for gcc 16 To: Tom de Vries , gdb-patches@sourceware.org References: <20260529125149.2027857-1-tdevries@suse.de> <20260529125149.2027857-3-tdevries@suse.de> From: Keith Seitz In-Reply-To: <20260529125149.2027857-3-tdevries@suse.de> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: JpXE9sc-mKhmZoutxkk_Plqb2Svo3FU6tRPNrIop4XY_1780071924 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi, On 5/29/26 5:51 AM, Tom de Vries wrote: > With gcc 16 and test-case gdb.cp/classes.exp I run into: > ... > classes.cc:440:15: warning: anonymous non-C-compatible type given name for linkage purposes by 'typedef' declaration [-Wnon-c-typedef-for-linkage]^M > 440 | typedef class {^M > | ^^M > | DynamicBase2^M > classes.cc:443:15: note: type is not C-compatible because it contains 'virtual int DynamicBase2::get_x()' declaration^M > 443 | virtual int get_x () { return x; }^M > | ^~~~~^M > ... > > Fix this by applying Wno-non-c-typedef-for-linkage, which is already done for > clang. > > Likewise for gdb.cp/class2.exp. This LGTM, just one little nit. > diff --git a/gdb/testsuite/gdb.cp/class2.exp b/gdb/testsuite/gdb.cp/class2.exp > index 705f51ac3e0..aa2a04467f4 100644 > --- a/gdb/testsuite/gdb.cp/class2.exp > +++ b/gdb/testsuite/gdb.cp/class2.exp > @@ -21,7 +21,8 @@ standard_testfile .cc > set flags [list debug c++] > # When using recent Clangs, this test fails to compile without this warning > # being disabled. However, older Clangs fail to recognize the flag. This comment could use a small update. > -if { [gcc_major_version "clang-*" "c++"] > 10 } { > +if { [gcc_major_version "clang-*" "c++"] > 10 > + || [gcc_major_version "gcc-*" "c++"] >= 16} { > lappend flags additional_flags=-Wno-non-c-typedef-for-linkage > } > Reviewed-By: Keith Seitz Thank you for fixing these. Keith