From: Michael Snyder <msnyder@vmware.com>
To: Doug Evans <dje@google.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Daniel Jacobowitz <drow@false.org>,
Pedro Alves <pedro@codesourcery.com>,
teawater <teawater@gmail.com>
Subject: Re: [RFA] Reverse Debugging, 1/5
Date: Fri, 03 Oct 2008 20:44:00 -0000 [thread overview]
Message-ID: <48E683BB.9030807@vmware.com> (raw)
In-Reply-To: <e394668d0810031203x44789ec5ke16c2416ff9b4b7a@mail.gmail.com>
Doug Evans wrote:
> On Wed, Oct 1, 2008 at 12:17 PM, Michael Snyder <msnyder@vmware.com> wrote:
>>
>> This first patch of the reverse debugging sequence affects
>> only the target_ops interface (adding several target methods
>> and some enums and such).
>>
>> Adding this patch alone does not affect gdb's behavior, and
>> I have run testsuites under RHEL with no change in results.
> Hi.
>
> Nit: Can all occurrences of "execdir" be replaced with
> "exec_direction"? I look at "execdir" and think "execution
> directory". [I realize often the context provides enough clues that
> prevent this misinterpretation, but that's not always true.]
Sure, if no one else objects, I'm fine with it.
Any other nits with this first part of the patch? Anyone?
next prev parent reply other threads:[~2008-10-03 20:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 19:18 Michael Snyder
2008-10-03 19:04 ` Doug Evans
2008-10-03 20:44 ` Michael Snyder [this message]
2008-10-06 20:30 ` Joel Brobecker
2008-10-06 21:03 ` Michael Snyder
2008-10-06 21:12 ` Daniel Jacobowitz
2008-10-06 21:20 ` Michael Snyder
2008-10-06 21:25 ` Daniel Jacobowitz
2008-10-06 21:46 ` Michael Snyder
2008-10-06 22:23 ` Joel Brobecker
2008-10-07 0:45 ` Michael Snyder
2008-10-07 3:49 ` Joel Brobecker
2008-10-07 18:30 ` Michael Snyder
2008-10-08 0:16 ` Joel Brobecker
2008-10-08 0:32 ` Michael Snyder
2008-10-08 0:55 ` Joel Brobecker
2008-10-08 1:46 ` Michael Snyder
2008-10-08 2:59 ` Joel Brobecker
2008-10-07 5:02 ` Daniel Jacobowitz
2008-10-06 21:45 ` Pedro Alves
2008-10-06 22:14 ` Michael Snyder
2008-10-06 22:35 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48E683BB.9030807@vmware.com \
--to=msnyder@vmware.com \
--cc=dje@google.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox