From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-58978-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15289 invoked by alias); 3 Oct 2008 20:44:28 -0000
Received: (qmail 15281 invoked by uid 22791); 3 Oct 2008 20:44:28 -0000
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.113.40.141)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 03 Oct 2008 20:43:53 +0000
Received: from mailhost2.vmware.com (mailhost2.vmware.com [10.16.67.167]) 	by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 97366675B; 	Fri,  3 Oct 2008 13:43:51 -0700 (PDT)
Received: from [10.20.92.59] (promb-2s-dhcp59.eng.vmware.com [10.20.92.59]) 	by mailhost2.vmware.com (Postfix) with ESMTP id 9573D8E589; 	Fri,  3 Oct 2008 13:43:51 -0700 (PDT)
Message-ID: <48E683BB.9030807@vmware.com>
Date: Fri, 03 Oct 2008 20:44:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 1.5.0.12 (X11/20080411)
MIME-Version: 1.0
To: Doug Evans <dje@google.com>
CC: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,   Daniel Jacobowitz <drow@false.org>,  Pedro Alves <pedro@codesourcery.com>, teawater <teawater@gmail.com>
Subject: Re: [RFA] Reverse Debugging, 1/5
References: <48E3CCB6.4060501@vmware.com> <e394668d0810031203x44789ec5ke16c2416ff9b4b7a@mail.gmail.com>
In-Reply-To: <e394668d0810031203x44789ec5ke16c2416ff9b4b7a@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-10/txt/msg00094.txt.bz2

Doug Evans wrote:
> On Wed, Oct 1, 2008 at 12:17 PM, Michael Snyder <msnyder@vmware.com> wrote:
>>
>> This first patch of the reverse debugging sequence affects
>> only the target_ops interface (adding several target methods
>> and some enums and such).
>>
>> Adding this patch alone does not affect gdb's behavior, and
>> I have run testsuites under RHEL with no change in results.

> Hi.
> 
> Nit: Can all occurrences of "execdir" be replaced with
> "exec_direction"?  I look at "execdir" and think "execution
> directory".  [I realize often the context provides enough clues that
> prevent this misinterpretation, but that's not always true.]

Sure, if no one else objects, I'm fine with it.

Any other nits with this first part of the patch?  Anyone?