From: Michael Snyder <msnyder@vmware.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Pedro Alves <pedro@codesourcery.com>,
teawater <teawater@gmail.com>
Subject: Re: [RFA] Reverse Debugging, 1/5
Date: Tue, 07 Oct 2008 18:30:00 -0000 [thread overview]
Message-ID: <48EBAA24.2080700@vmware.com> (raw)
In-Reply-To: <20081007034840.GE28138@adacore.com>
Joel Brobecker wrote:
>> Before I actually implement this, let me see if we're all
>> on the same page (Daniel, Joel, Pedro...)
>
> My own view was a little simpler: Delete the target_set_execdir method,
I'm guessing you meant "get" here?
> and replace all the calls with a reference to the infrun global. I would
> keep the target_set_execdir more or less as is; otherwise, you'll need
> some kind of observer to notice when the execdir changes. The
> "to_can_go_backwards" is an interesting idea, but in my opinion only
> makes sense if the target_set_execdir method is removed. Otherwise,
> we can treat target_set_execdir == NULL as cannot-go-backwards.
OK, so you're saying that "target_set_execdir" will set the
global infrun variable, not a target-defined variable?
I would have thought somebody would object to that on semantic grounds.
Then the only reason to put it into the target vector is so that
we can check for "cannot-go-backwards", and surely someone will
come back and tell me "well that is what you should call it then".
next prev parent reply other threads:[~2008-10-07 18:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 19:18 Michael Snyder
2008-10-03 19:04 ` Doug Evans
2008-10-03 20:44 ` Michael Snyder
2008-10-06 20:30 ` Joel Brobecker
2008-10-06 21:03 ` Michael Snyder
2008-10-06 21:12 ` Daniel Jacobowitz
2008-10-06 21:20 ` Michael Snyder
2008-10-06 21:25 ` Daniel Jacobowitz
2008-10-06 21:46 ` Michael Snyder
2008-10-06 22:23 ` Joel Brobecker
2008-10-07 0:45 ` Michael Snyder
2008-10-07 3:49 ` Joel Brobecker
2008-10-07 18:30 ` Michael Snyder [this message]
2008-10-08 0:16 ` Joel Brobecker
2008-10-08 0:32 ` Michael Snyder
2008-10-08 0:55 ` Joel Brobecker
2008-10-08 1:46 ` Michael Snyder
2008-10-08 2:59 ` Joel Brobecker
2008-10-07 5:02 ` Daniel Jacobowitz
2008-10-06 21:45 ` Pedro Alves
2008-10-06 22:14 ` Michael Snyder
2008-10-06 22:35 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48EBAA24.2080700@vmware.com \
--to=msnyder@vmware.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox