Re: [PATCH 0/4] 'catch syscall' feature

[Michael Snyder <msnyder@vmware.com>]

Sérgio Durigan Júnior wrote:

> On Wed, 2008-10-01 at 16:51 -0700, Michael Snyder wrote:
> 
>> I was able to build this, but it failed your test case
>> (thanks very much for including a test case, by the way).
>> I'm attaching my failing gdb.log.
> 
> Well, maybe you have misunderstood things (or maybe I wasn't clear
> enough :-)). Currently, my patch only works for 32-bit PowerPC
> architecture, although I intend to implement the x86 support ASAP.

Ah, well now I'm embarrassed.   ;-)
In that case I can't test it, but I can only do "static analysis".

+/* To be used when one needs to know wether a
+   WSTOPSIG (status) is a syscall */

"Whether".  And you need a period and two spaces.

+/* Determine wether we support PTRACE_O_TRACESYSGOOD option available.
+   This function also sets linux_supports_tracesysgood_flag. */

"Whether".  Two spaces after final period.

+/* A number to represent wether we are catching any syscalls. */

Same again.

+  /* Signal wether we are in a SYSCALL_ENTRY or

...

Do a search for ". */", and add a second space.

Otherwise, the code looks pretty good, and I like the idea.

Michael