From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5424 invoked by alias); 2 Oct 2008 22:01:49 -0000 Received: (qmail 5407 invoked by uid 22791); 2 Oct 2008 22:01:48 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.113.40.141) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 02 Oct 2008 22:01:08 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id A68A4687C; Thu, 2 Oct 2008 15:01:06 -0700 (PDT) Received: from [10.20.92.59] (promb-2s-dhcp59.eng.vmware.com [10.20.92.59]) by mailhost4.vmware.com (Postfix) with ESMTP id 62073C9A2B; Thu, 2 Oct 2008 15:01:06 -0700 (PDT) Message-ID: <48E54460.2090401@vmware.com> Date: Thu, 02 Oct 2008 22:01:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: =?ISO-8859-1?Q?S=E9rgio_Durigan_J=FAnior?= CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH 0/4] 'catch syscall' feature References: <1222798405.30389.22.camel@miki> <48E3FBE1.9030800@vmware.com> <1222902189.19318.8.camel@miki> <48E40CF3.5090702@vmware.com> <1222919302.19318.18.camel@miki> In-Reply-To: <1222919302.19318.18.camel@miki> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00066.txt.bz2 Sérgio Durigan Júnior wrote: > On Wed, 2008-10-01 at 16:51 -0700, Michael Snyder wrote: > >> I was able to build this, but it failed your test case >> (thanks very much for including a test case, by the way). >> I'm attaching my failing gdb.log. > > Well, maybe you have misunderstood things (or maybe I wasn't clear > enough :-)). Currently, my patch only works for 32-bit PowerPC > architecture, although I intend to implement the x86 support ASAP. Ah, well now I'm embarrassed. ;-) In that case I can't test it, but I can only do "static analysis". +/* To be used when one needs to know wether a + WSTOPSIG (status) is a syscall */ "Whether". And you need a period and two spaces. +/* Determine wether we support PTRACE_O_TRACESYSGOOD option available. + This function also sets linux_supports_tracesysgood_flag. */ "Whether". Two spaces after final period. +/* A number to represent wether we are catching any syscalls. */ Same again. + /* Signal wether we are in a SYSCALL_ENTRY or ... Do a search for ". */", and add a second space. Otherwise, the code looks pretty good, and I like the idea. Michael