Re: [PATCH 0/4] 'catch syscall' feature

["Sérgio Durigan Júnior" <sergiodj@linux.vnet.ibm.com>]

Hey Michael :-),

On Thu, 2008-10-02 at 15:00 -0700, Michael Snyder wrote:
> Sérgio Durigan Júnior wrote:
> 
> > On Wed, 2008-10-01 at 16:51 -0700, Michael Snyder wrote:
> > 
> >> I was able to build this, but it failed your test case
> >> (thanks very much for including a test case, by the way).
> >> I'm attaching my failing gdb.log.
> > 
> > Well, maybe you have misunderstood things (or maybe I wasn't clear
> > enough :-)). Currently, my patch only works for 32-bit PowerPC
> > architecture, although I intend to implement the x86 support ASAP.
> 
> Ah, well now I'm embarrassed.   ;-)
> In that case I can't test it, but I can only do "static analysis".

Which is already a pretty good thing. Thanks for that.

> +/* To be used when one needs to know wether a
> +   WSTOPSIG (status) is a syscall */
> 
> "Whether".  And you need a period and two spaces.

Thanks for the correction, and sorry about my bad english (not only in
this case, but in every other). I'll fix this, and I'll add the two
spaces after the period.



> Otherwise, the code looks pretty good, and I like the idea.

Thanks!

-- 
Sérgio Durigan Júnior
Linux on Power Toolchain - Software Engineer
Linux Technology Center - LTC
IBM Brazil