From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16490 invoked by alias); 3 Oct 2008 02:14:58 -0000 Received: (qmail 16481 invoked by uid 22791); 3 Oct 2008 02:14:57 -0000 X-Spam-Check-By: sourceware.org Received: from igw1.br.ibm.com (HELO igw1.br.ibm.com) (32.104.18.24) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 03 Oct 2008 02:14:13 +0000 Received: from d24relay01.br.ibm.com (unknown [9.8.31.16]) by igw1.br.ibm.com (Postfix) with ESMTP id 2C13F32C156 for ; Thu, 2 Oct 2008 22:42:31 -0300 (BRT) Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.18.232.47]) by d24relay01.br.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id m932E0XB2695308 for ; Thu, 2 Oct 2008 23:14:00 -0300 Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) by d24av02.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m932E7kq024678 for ; Thu, 2 Oct 2008 23:14:07 -0300 Received: from [9.18.199.7] ([9.18.199.7]) by d24av02.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m932E7mu024673; Thu, 2 Oct 2008 23:14:07 -0300 Subject: Re: [PATCH 0/4] 'catch syscall' feature From: =?ISO-8859-1?Q?S=E9rgio?= Durigan =?ISO-8859-1?Q?J=FAnior?= To: Michael Snyder Cc: "gdb-patches@sourceware.org" In-Reply-To: <48E54460.2090401@vmware.com> References: <1222798405.30389.22.camel@miki> <48E3FBE1.9030800@vmware.com> <1222902189.19318.8.camel@miki> <48E40CF3.5090702@vmware.com> <1222919302.19318.18.camel@miki> <48E54460.2090401@vmware.com> Content-Type: text/plain; charset=iso-8859-1 Date: Fri, 03 Oct 2008 02:14:00 -0000 Message-Id: <1223000150.9858.1.camel@miki> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00077.txt.bz2 Hey Michael :-), On Thu, 2008-10-02 at 15:00 -0700, Michael Snyder wrote: > Sérgio Durigan Júnior wrote: > > > On Wed, 2008-10-01 at 16:51 -0700, Michael Snyder wrote: > > > >> I was able to build this, but it failed your test case > >> (thanks very much for including a test case, by the way). > >> I'm attaching my failing gdb.log. > > > > Well, maybe you have misunderstood things (or maybe I wasn't clear > > enough :-)). Currently, my patch only works for 32-bit PowerPC > > architecture, although I intend to implement the x86 support ASAP. > > Ah, well now I'm embarrassed. ;-) > In that case I can't test it, but I can only do "static analysis". Which is already a pretty good thing. Thanks for that. > +/* To be used when one needs to know wether a > + WSTOPSIG (status) is a syscall */ > > "Whether". And you need a period and two spaces. Thanks for the correction, and sorry about my bad english (not only in this case, but in every other). I'll fix this, and I'll add the two spaces after the period. > Otherwise, the code looks pretty good, and I like the idea. Thanks! -- Sérgio Durigan Júnior Linux on Power Toolchain - Software Engineer Linux Technology Center - LTC IBM Brazil