Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Aleksandar Ristovski <aristovski@qnx.com>
To: gdb-patches@sources.redhat.com
Cc: Eli Zaretskii <eliz@gnu.org>, Daniel Jacobowitz <drow@false.org>
Subject: Re: [RFC] new substitute path when loading feature
Date: Fri, 16 May 2008 08:15:00 -0000	[thread overview]
Message-ID: <482C91AA.30903@qnx.com> (raw)
In-Reply-To: <20080515193513.GA17156@caradoc.them.org>

Daniel Jacobowitz wrote:
> On Thu, May 15, 2008 at 10:28:10PM +0300, Eli Zaretskii wrote:
>>> Date: Thu, 15 May 2008 15:16:42 -0400
>>> From: Daniel Jacobowitz <drow@false.org>
>>> Cc: aristovski@qnx.com, gdb-patches@sources.redhat.com
>>>
>>> I'm happy to add the band-aid; do you have an idea of what to call it?
>>> set strict-filenames?
>> How about "set support-dos-filenames" (on by default)?
> 
> I like that better, thanks!  I'll work on the option (not right now).
>

You will probably want this wrapped in an if. In fact, I don't see how will it work properly with only one flag - we probably don't want to do case-insensitive compare by default, but we do need to compare case insensitive for dos-like file system.
 
#ifndef HAVE_DOS_BASED_FILE_SYSTEM
+      /* When debugging on a POSIX host, assume that each filename was
+	 recorded with a single consistent capitalization during
+	 compilation.  Source trees are too likely to contain both
+	 main.c and Main.c.  */
+      if (*lhs == *rhs)
+	continue;
+#else
+      if (tolower (*lhs) == tolower (*rhs))
+	continue;
+#endif
+


WARNING: multiple messages have this Message-ID
From: Aleksandar Ristovski <aristovski@qnx.com>
To: gdb-patches@sources.redhat.com
Cc: Eli Zaretskii <eliz@gnu.org>, Daniel Jacobowitz <drow@false.org>
Subject: Re: [RFC] new substitute path when loading feature
Date: Fri, 16 May 2008 08:19:00 -0000	[thread overview]
Message-ID: <482C91AA.30903@qnx.com> (raw)
Message-ID: <20080516081900.84oPBq3cS-g8bqjvaNd5GBfroGa82u9UGOntovqW-t4@z> (raw)
In-Reply-To: <20080515193513.GA17156@caradoc.them.org>

Daniel Jacobowitz wrote:
> On Thu, May 15, 2008 at 10:28:10PM +0300, Eli Zaretskii wrote:
>>> Date: Thu, 15 May 2008 15:16:42 -0400
>>> From: Daniel Jacobowitz <drow@false.org>
>>> Cc: aristovski@qnx.com, gdb-patches@sources.redhat.com
>>>
>>> I'm happy to add the band-aid; do you have an idea of what to call it?
>>> set strict-filenames?
>> How about "set support-dos-filenames" (on by default)?
> 
> I like that better, thanks!  I'll work on the option (not right now).
>

You will probably want this wrapped in an if. In fact, I don't see how will it work properly with only one flag - we probably don't want to do case-insensitive compare by default, but we do need to compare case insensitive for dos-like file system.
 
#ifndef HAVE_DOS_BASED_FILE_SYSTEM
+      /* When debugging on a POSIX host, assume that each filename was
+	 recorded with a single consistent capitalization during
+	 compilation.  Source trees are too likely to contain both
+	 main.c and Main.c.  */
+      if (*lhs == *rhs)
+	continue;
+#else
+      if (tolower (*lhs) == tolower (*rhs))
+	continue;
+#endif
+


  reply	other threads:[~2008-05-15 19:40 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-13 18:56 Aleksandar Ristovski
2008-05-13 19:00 ` Daniel Jacobowitz
2008-05-13 20:24   ` Aleksandar Ristovski
2008-05-13 21:11     ` Daniel Jacobowitz
2008-05-13 21:18       ` Aleksandar Ristovski
2008-05-13 21:40         ` Daniel Jacobowitz
2008-05-15 17:37           ` Daniel Jacobowitz
2008-05-15 19:29             ` Joel Brobecker
2008-05-15 19:30             ` Eli Zaretskii
2008-05-15 19:44               ` Daniel Jacobowitz
2008-05-15 22:40                 ` Eli Zaretskii
2008-05-16  0:28                   ` Daniel Jacobowitz
2008-05-16  8:15                     ` Aleksandar Ristovski [this message]
2008-05-16  8:19                       ` Aleksandar Ristovski
2008-05-16  8:21                       ` Daniel Jacobowitz
2008-05-16 15:26                         ` Mark Kettenis
2008-05-16 15:27                           ` Eli Zaretskii
2008-05-16 15:27                         ` Aleksandar Ristovski
2008-05-16 15:27                           ` Aleksandar Ristovski
2008-05-16 15:27                           ` Eli Zaretskii
2008-05-16 19:21                             ` Aleksandar Ristovski
2008-05-16 19:35                               ` Eli Zaretskii
2008-05-16 19:22                             ` Aleksandar Ristovski
2008-05-16 15:26                       ` Eli Zaretskii
2008-05-15 20:05               ` Joel Brobecker
2008-05-15 19:35             ` Aleksandar Ristovski
2008-05-17 19:49             ` Vladimir Prus
2008-05-19  4:12               ` Vladimir Prus
2008-05-13 21:12     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=482C91AA.30903@qnx.com \
    --to=aristovski@qnx.com \
    --cc=drow@false.org \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox