From: Vladimir Prus <vladimir@codesourcery.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFC] new substitute path when loading feature
Date: Sat, 17 May 2008 19:49:00 -0000 [thread overview]
Message-ID: <g0mmmn$paj$1@ger.gmane.org> (raw)
In-Reply-To: <20080515160551.GA24101@caradoc.them.org>
Daniel Jacobowitz wrote:
> On Tue, May 13, 2008 at 03:20:41PM -0400, Daniel Jacobowitz wrote:
>> On Tue, May 13, 2008 at 03:11:22PM -0400, Aleksandar Ristovski wrote:
>> > No, this particular issue is not because of the slashes, but rather
>> > due to IS_ABSOLUTE_PATH returning false on a path like "c:/Temp...".
>>
>> OK. I think I "fixed" FILENAME_CMP and not IS_ABSOLUTE_PATH, but it
>> would not be hard to do both.
>>
>> I'll try to post something tonight.
>
> Sorry, my existing patch was a mess so I had to rewrite it. I haven't
> really tested this; it doesn't break a native Linux GDB in any case
> that I consider significant. See the comments in defs.h and utils.c
> for the details.
I probably miss somethings, but it looks like the uses of IS_ABSOLUTE_PATH
in symtab.c:lookup_symtab and symtab.c:lookup_partial_symtab should be changed to
GDB_IS_ABSOLUTE_PATH, too?
Also, I see IS_ABSOLUTE_PATH been used in source.c:openp, inside the
"if (filename_opened)" block at the end, and your patch does not seem to change
that.
- Volodya
next prev parent reply other threads:[~2008-05-17 13:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 18:56 Aleksandar Ristovski
2008-05-13 19:00 ` Daniel Jacobowitz
2008-05-13 20:24 ` Aleksandar Ristovski
2008-05-13 21:11 ` Daniel Jacobowitz
2008-05-13 21:18 ` Aleksandar Ristovski
2008-05-13 21:40 ` Daniel Jacobowitz
2008-05-15 17:37 ` Daniel Jacobowitz
2008-05-15 19:29 ` Joel Brobecker
2008-05-15 19:30 ` Eli Zaretskii
2008-05-15 19:44 ` Daniel Jacobowitz
2008-05-15 22:40 ` Eli Zaretskii
2008-05-16 0:28 ` Daniel Jacobowitz
2008-05-16 8:15 ` Aleksandar Ristovski
2008-05-16 8:19 ` Aleksandar Ristovski
2008-05-16 8:21 ` Daniel Jacobowitz
2008-05-16 15:26 ` Mark Kettenis
2008-05-16 15:27 ` Eli Zaretskii
2008-05-16 15:27 ` Aleksandar Ristovski
2008-05-16 15:27 ` Eli Zaretskii
2008-05-16 19:21 ` Aleksandar Ristovski
2008-05-16 19:35 ` Eli Zaretskii
2008-05-16 19:22 ` Aleksandar Ristovski
2008-05-16 15:27 ` Aleksandar Ristovski
2008-05-16 15:26 ` Eli Zaretskii
2008-05-15 20:05 ` Joel Brobecker
2008-05-15 19:35 ` Aleksandar Ristovski
2008-05-17 19:49 ` Vladimir Prus [this message]
2008-05-19 4:12 ` Vladimir Prus
2008-05-13 21:12 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='g0mmmn$paj$1@ger.gmane.org' \
--to=vladimir@codesourcery.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox