RE: [PATCH] Fix for 64-Bit Core Files on AIX

["Roberts, Dennis" <Dennis.Roberts@sunquestinfo.com>]

Hi Joel,

Yes, I did a quick manual test with both 32- and 64-bit core files and executables to make sure that the changes worked as expected.  I also ran the testsuite several times before and after the change was made to make sure that there were no adverse side-effects.  The only caveat is that the only version of AIX that I was able to use for testing was 5.3.0.0.

I would be interested in providing a copyright assignment to the FSF.  How would I go about doing that?

Thanks,
Dennis

-----Original Message-----
From: Joel Brobecker [mailto:brobecker@adacore.com]
Sent: Wednesday, April 16, 2008 2:16 PM
To: Roberts, Dennis
Cc: 'gdb-patches@sourceware.org'
Subject: Re: [PATCH] Fix for 64-Bit Core Files on AIX

Dennis,

> 2008-04-15  Dennis Roberts  <dennis.roberts@sunquestinfo.com>
>
>       * rs6000-tdep.c (rs6000_gdbarch_init): Use the BFD architecture,
>       rather than a hard-coded architecture, for xcoff executables.

I have reviewed the change, and it looks OK (and can be applied independently of the BFD part). But I just wanted to make sure that you have indeed tested this change both in 32 and 64 bit modes.
Is that correct?

The change is sufficiently small that it qualifies as a non-legally significant change (patch repeated at the end of this email for quick reference), but if you think you are going to make more contributions, I would encourage you to provide a copyright assignment to the FSF.
We could then offer you write access to the repository.  I can help you get started if you like.

In the meantime, I will commit your change as soon as you have confirmed testing.

Thank you,
--
Joel

> diff -rc src.orig/gdb/rs6000-tdep.c src/gdb/rs6000-tdep.c
> *** src.orig/gdb/rs6000-tdep.c        Wed Feb 20 07:34:43 2008
> --- src/gdb/rs6000-tdep.c     Tue Apr 15 13:33:10 2008
> ***************
> *** 3307,3324 ****
>       wordsize = 4;
>       }
>
> !   if (!from_xcoff_exec)
> !     {
> !       arch = info.bfd_arch_info->arch;
> !       mach = info.bfd_arch_info->mach;
> !     }
> !   else
> !     {
> !       arch = bfd_arch_powerpc;
> !       bfd_default_set_arch_mach (&abfd, arch, 0);
> !       info.bfd_arch_info = bfd_get_arch_info (&abfd);
> !       mach = info.bfd_arch_info->mach;
> !     }
>
>     /* For e500 executables, the apuinfo section is of help here.  Such
>        section contains the identifier and revision number of each
> --- 3307,3315 ----
>       wordsize = 4;
>       }
>
> !   /* Get the architecture and machine from the BFD. */
> !   arch = info.bfd_arch_info->arch;
> !   mach = info.bfd_arch_info->mach;
>
>     /* For e500 executables, the apuinfo section is of help here.  Such
>        section contains the identifier and revision number of each