From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19938 invoked by alias); 16 Apr 2008 21:22:34 -0000 Received: (qmail 19928 invoked by uid 22791); 16 Apr 2008 21:22:33 -0000 X-Spam-Check-By: sourceware.org Received: from smtp1.sunquestinfo.com (HELO azbarracuda.sunquestinfo.com) (149.138.25.7) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 16 Apr 2008 21:22:13 +0000 Received: from sqex4.sunquestinfo.com (localhost [127.0.0.1]) by azbarracuda.sunquestinfo.com (Spam Firewall) with ESMTP id C22E51D6A2D; Wed, 16 Apr 2008 14:22:11 -0700 (MST) Received: from sqex4.sunquestinfo.com (sqex4.sunquestinfo.com [149.138.60.208]) by azbarracuda.sunquestinfo.com with ESMTP id Uo3dNHOIrAj0EALH; Wed, 16 Apr 2008 14:22:11 -0700 (MST) Received: from SQMAILBOX1.sunquestinfo.com ([10.105.61.111]) by sqex4.sunquestinfo.com ([149.138.60.208]) with mapi; Wed, 16 Apr 2008 14:22:11 -0700 From: "Roberts, Dennis" To: 'Joel Brobecker' CC: "'gdb-patches@sourceware.org'" Date: Wed, 16 Apr 2008 21:55:00 -0000 Subject: RE: [PATCH] Fix for 64-Bit Core Files on AIX Message-ID: <4813EA4A50D35A44906A74A5E341D0B61A03388657@SQMAILBOX1.sunquestinfo.com> References: <4813EA4A50D35A44906A74A5E341D0B61A03388643@SQMAILBOX1.sunquestinfo.com> <20080416211607.GD3631@adacore.com> In-Reply-To: <20080416211607.GD3631@adacore.com> Accept-Language: en-US Content-Language: en-US acceptlanguage: en-US x-tm-as-product-ver: SMEX-8.0.0.1181-5.000.1023-15852.005 x-tm-as-result: No--40.264000-8.000000-31 x-tm-as-user-approved-sender: No x-tm-as-user-blocked-sender: No Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00310.txt.bz2 Hi Joel, Yes, I did a quick manual test with both 32- and 64-bit core files and exec= utables to make sure that the changes worked as expected. I also ran the t= estsuite several times before and after the change was made to make sure th= at there were no adverse side-effects. The only caveat is that the only ve= rsion of AIX that I was able to use for testing was 5.3.0.0. I would be interested in providing a copyright assignment to the FSF. How = would I go about doing that? Thanks, Dennis -----Original Message----- From: Joel Brobecker [mailto:brobecker@adacore.com] Sent: Wednesday, April 16, 2008 2:16 PM To: Roberts, Dennis Cc: 'gdb-patches@sourceware.org' Subject: Re: [PATCH] Fix for 64-Bit Core Files on AIX Dennis, > 2008-04-15 Dennis Roberts > > * rs6000-tdep.c (rs6000_gdbarch_init): Use the BFD architecture, > rather than a hard-coded architecture, for xcoff executables. I have reviewed the change, and it looks OK (and can be applied independent= ly of the BFD part). But I just wanted to make sure that you have indeed te= sted this change both in 32 and 64 bit modes. Is that correct? The change is sufficiently small that it qualifies as a non-legally signifi= cant change (patch repeated at the end of this email for quick reference), = but if you think you are going to make more contributions, I would encourag= e you to provide a copyright assignment to the FSF. We could then offer you write access to the repository. I can help you get= started if you like. In the meantime, I will commit your change as soon as you have confirmed te= sting. Thank you, -- Joel > diff -rc src.orig/gdb/rs6000-tdep.c src/gdb/rs6000-tdep.c > *** src.orig/gdb/rs6000-tdep.c Wed Feb 20 07:34:43 2008 > --- src/gdb/rs6000-tdep.c Tue Apr 15 13:33:10 2008 > *************** > *** 3307,3324 **** > wordsize =3D 4; > } > > ! if (!from_xcoff_exec) > ! { > ! arch =3D info.bfd_arch_info->arch; > ! mach =3D info.bfd_arch_info->mach; > ! } > ! else > ! { > ! arch =3D bfd_arch_powerpc; > ! bfd_default_set_arch_mach (&abfd, arch, 0); > ! info.bfd_arch_info =3D bfd_get_arch_info (&abfd); > ! mach =3D info.bfd_arch_info->mach; > ! } > > /* For e500 executables, the apuinfo section is of help here. Such > section contains the identifier and revision number of each > --- 3307,3315 ---- > wordsize =3D 4; > } > > ! /* Get the architecture and machine from the BFD. */ > ! arch =3D info.bfd_arch_info->arch; > ! mach =3D info.bfd_arch_info->mach; > > /* For e500 executables, the apuinfo section is of help here. Such > section contains the identifier and revision number of each