Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: "Roberts, Dennis" <Dennis.Roberts@sunquestinfo.com>
Cc: "'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix for 64-Bit Core Files on AIX
Date: Thu, 17 Apr 2008 21:16:00 -0000	[thread overview]
Message-ID: <20080417210842.GB12735@adacore.com> (raw)
In-Reply-To: <20080416215451.GE3626@adacore.com>

> > Yes, I did a quick manual test with both 32- and 64-bit core files and
> > executables to make sure that the changes worked as expected.  I also
> > ran the testsuite several times before and after the change was made
> > to make sure that there were no adverse side-effects.  The only caveat
> > is that the only version of AIX that I was able to use for testing was
> > 5.3.0.0.
> 
> Thanks for confirming the testing. I will see if I can test the change
> on AIX 5.1 and then commit it.

I wasn't able to test this change on 5.1 as our 5.1 machine apparently
stopped working a while ago. I did some testing on 5.2, and then
committed your patch.

Just a couple of additional remarks:

  - I fixed a missing space at the end of your comment:
      /* Your comment should have too space after the dot.  */

  - Would it be much work for you to change the MIME type used for
    your patches? Right now, it's application/octet-stream which
    makes it harder to read and reply to.

Would you mind letting us know when the BFD part is checked in, and
we'll add a NEWS entry for this new feature.

Thank you,
-- 
Joel


  parent reply	other threads:[~2008-04-17 21:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-16  8:12 Roberts, Dennis
2008-04-16 21:34 ` Joel Brobecker
2008-04-16 21:55   ` Roberts, Dennis
2008-04-16 22:25     ` Joel Brobecker
2008-04-16 22:40       ` Roberts, Dennis
2008-04-17 21:16       ` Joel Brobecker [this message]
2008-04-17 21:25         ` Roberts, Dennis
2008-04-18 18:48         ` Roberts, Dennis
2008-04-19  1:26           ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080417210842.GB12735@adacore.com \
    --to=brobecker@adacore.com \
    --cc=Dennis.Roberts@sunquestinfo.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox