From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24444 invoked by alias); 17 Apr 2008 21:09:04 -0000 Received: (qmail 24435 invoked by uid 22791); 17 Apr 2008 21:09:04 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 17 Apr 2008 21:08:46 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3258B2AA243; Thu, 17 Apr 2008 17:08:45 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id hpy44fP7J44s; Thu, 17 Apr 2008 17:08:45 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id EB0DE2AA21C; Thu, 17 Apr 2008 17:08:44 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id CBF39E7ACD; Thu, 17 Apr 2008 14:08:42 -0700 (PDT) Date: Thu, 17 Apr 2008 21:16:00 -0000 From: Joel Brobecker To: "Roberts, Dennis" Cc: "'gdb-patches@sourceware.org'" Subject: Re: [PATCH] Fix for 64-Bit Core Files on AIX Message-ID: <20080417210842.GB12735@adacore.com> References: <4813EA4A50D35A44906A74A5E341D0B61A03388643@SQMAILBOX1.sunquestinfo.com> <20080416211607.GD3631@adacore.com> <4813EA4A50D35A44906A74A5E341D0B61A03388657@SQMAILBOX1.sunquestinfo.com> <20080416215451.GE3626@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080416215451.GE3626@adacore.com> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-04/txt/msg00363.txt.bz2 > > Yes, I did a quick manual test with both 32- and 64-bit core files and > > executables to make sure that the changes worked as expected. I also > > ran the testsuite several times before and after the change was made > > to make sure that there were no adverse side-effects. The only caveat > > is that the only version of AIX that I was able to use for testing was > > 5.3.0.0. > > Thanks for confirming the testing. I will see if I can test the change > on AIX 5.1 and then commit it. I wasn't able to test this change on 5.1 as our 5.1 machine apparently stopped working a while ago. I did some testing on 5.2, and then committed your patch. Just a couple of additional remarks: - I fixed a missing space at the end of your comment: /* Your comment should have too space after the dot. */ - Would it be much work for you to change the MIME type used for your patches? Right now, it's application/octet-stream which makes it harder to read and reply to. Would you mind letting us know when the BFD part is checked in, and we'll add a NEWS entry for this new feature. Thank you, -- Joel