Re: [patch] Remove comments from user_code in gdb_test_multiple

[Markus Deuling <deuling@de.ibm.com>]

Andrew STUBBS schrieb:
> Markus Deuling wrote:
>> What do you think about the spu info mailbox patch then ? Move the 
>> comment above gdb_test_multiple ? Or use send_gdb/gdb_expect and have 
>> the comments in the right place?
> 
> The (?#) directive allows you to put the comments inside the regular 
> expression itself.
> 
>    -re "(?#Older kernels had a bug that caused them to return arbitrary 
> values when
>            attempting to read from an empty mailbox via spufs.
>         )SPU Outbound Mailbox.*0x.*SPU Outbound Interrupt 
> Mailbox.*0x.*$gdb_prompt $"
> 
> Or, alternatively, the (?x) directive might be cleaner. Note that this 
> changes the meaning of white space.
> 
>    -re "(?x)
>         #Older kernels had a bug that caused them to return arbitrary 
> values when
>         #attempting to read from an empty mailbox via spufs.
>         SPU Outbound Mailbox.*0x.*SPU Outbound Interrupt Mailbox.*0x.*
>         $gdb_prompt[ ]$"
> 
> 
> This is untested!
> 
> Andrew
> 

This is interesting, thank you! Is this documented somewhere? Maybe it would be a good idea
to add one or two lines above gdb_test_multiple or in the Internal's Manual. What do you think ?

Regards,
Markus

-- 
  Markus Deuling
  GNU Toolchain for Linux on Cell BE
  deuling@de.ibm.com