From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8707 invoked by alias); 28 Mar 2008 08:57:55 -0000 Received: (qmail 8699 invoked by uid 22791); 28 Mar 2008 08:57:54 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 28 Mar 2008 08:57:32 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id m2S8vUYm286780 for ; Fri, 28 Mar 2008 08:57:30 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m2S8vUsr4304902 for ; Fri, 28 Mar 2008 09:57:30 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m2S8vTVQ013098 for ; Fri, 28 Mar 2008 09:57:29 +0100 Received: from bbkeks.de.ibm.com (sig-9-146-226-69.de.ibm.com [9.146.226.69]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m2S8vQxa013024 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 28 Mar 2008 09:57:28 +0100 Message-ID: <47ECB2F7.7060206@de.ibm.com> Date: Fri, 28 Mar 2008 08:57:00 -0000 From: Markus Deuling User-Agent: Thunderbird 2.0.0.12 (X11/20080213) MIME-Version: 1.0 To: Andrew STUBBS CC: Markus Deuling , Daniel Jacobowitz , Ulrich Weigand , GDB Patches Subject: Re: [patch] Remove comments from user_code in gdb_test_multiple References: <47EBBBFA.4010700@de.ibm.com> <20080327153159.GA8060@caradoc.them.org> <47EBC15C.6070306@de.ibm.com> <47EBCCBC.8020706@st.com> In-Reply-To: <47EBCCBC.8020706@st.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00456.txt.bz2 Andrew STUBBS schrieb: > Markus Deuling wrote: >> What do you think about the spu info mailbox patch then ? Move the >> comment above gdb_test_multiple ? Or use send_gdb/gdb_expect and have >> the comments in the right place? > > The (?#) directive allows you to put the comments inside the regular > expression itself. > > -re "(?#Older kernels had a bug that caused them to return arbitrary > values when > attempting to read from an empty mailbox via spufs. > )SPU Outbound Mailbox.*0x.*SPU Outbound Interrupt > Mailbox.*0x.*$gdb_prompt $" > > Or, alternatively, the (?x) directive might be cleaner. Note that this > changes the meaning of white space. > > -re "(?x) > #Older kernels had a bug that caused them to return arbitrary > values when > #attempting to read from an empty mailbox via spufs. > SPU Outbound Mailbox.*0x.*SPU Outbound Interrupt Mailbox.*0x.* > $gdb_prompt[ ]$" > > > This is untested! > > Andrew > This is interesting, thank you! Is this documented somewhere? Maybe it would be a good idea to add one or two lines above gdb_test_multiple or in the Internal's Manual. What do you think ? Regards, Markus -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com