Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Markus Deuling <deuling@de.ibm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
		Ulrich Weigand <uweigand@de.ibm.com>
Subject: Re: [patch] Remove comments from user_code in gdb_test_multiple
Date: Thu, 27 Mar 2008 15:32:00 -0000	[thread overview]
Message-ID: <20080327153159.GA8060@caradoc.them.org> (raw)
In-Reply-To: <47EBBBFA.4010700@de.ibm.com>

On Thu, Mar 27, 2008 at 04:23:38PM +0100, Markus Deuling wrote:
> Hi,
>
> this patch removes all comments from user_code given to gdb_test_multiple. This allows
> to have comments in code snippets given to gdb_test_multiple like for exmaple proposed
> in this patch:
>
> http://sourceware.org/ml/gdb-patches/2008-03/msg00290.html
>
>
> ChangeLog:
>
> 	* lib/gdb.exp (gdb_test_multiple): Remove comments from user_code.
>
> Ok ?

Won't this eat quoted # signs in the middle of patterns?
I suggest you move the comment inside the code block where it would be
valid, instead.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2008-03-27 15:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-27 15:24 Markus Deuling
2008-03-27 15:32 ` Daniel Jacobowitz [this message]
2008-03-27 15:47   ` Markus Deuling
2008-03-27 15:55     ` Daniel Jacobowitz
2008-03-27 17:52       ` Ulrich Weigand
2008-03-28  9:16         ` Markus Deuling
2008-03-28 16:00           ` Ulrich Weigand
2008-03-31  8:42             ` Markus Deuling
2008-03-27 16:35     ` Andrew STUBBS
2008-03-28  8:57       ` Markus Deuling
2008-03-28  9:40         ` Andrew STUBBS

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080327153159.GA8060@caradoc.them.org \
    --to=drow@false.org \
    --cc=deuling@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox