Re: [rfc] Fix info spu mailbox command

[Markus Deuling <deuling@de.ibm.com>]

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

Ulrich Weigand schrieb:
> Markus Deuling:
> 
>>         * gdb.arch/spu-info.exp (info spu mailbox): Use correct initialisation
>>         value.
> 
> This is OK.  Even better would be to XFAIL (instead of FAIL) the new test
> on old kernels ...
> 

Hi Uli,

now the test XFAILs on old kernels without Jeremy's patch.
Ok ?


-- 
  Markus Deuling
  GNU Toolchain for Linux on Cell BE
  deuling@de.ibm.com


[-- Attachment #2: fix-spu-mailbox --]
[-- Type: text/plain, Size: 960 bytes --]

diff -urpN src/gdb/testsuite/gdb.arch/spu-info.exp dev/gdb/testsuite/gdb.arch/spu-info.exp
--- src/gdb/testsuite/gdb.arch/spu-info.exp	2008-01-01 23:53:18.000000000 +0100
+++ dev/gdb/testsuite/gdb.arch/spu-info.exp	2008-03-17 15:56:55.000000000 +0100
@@ -200,9 +200,14 @@ gdb_test "finish" "" "finish"
 # Mailbox Test
 # 'info spu mailbox' should be empty.
 c_to "Marker Mbox"
-gdb_test "info spu mailbox" \
-	 "SPU Outbound Mailbox.*0xc0000000.*SPU Outbound Interrupt Mailbox.*0xc0000000.*" \
-	 "info spu mailbox"
+send_gdb "info spu mailbox\n"
+gdb_expect {
+  -re "SPU Outbound Mailbox.*0xc0000000.*SPU Outbound Interrupt Mailbox.*0xc0000000.*$gdb_prompt $"\
+      { xfail "info spu mailbox" }
+  -re "SPU Outbound Mailbox.*0x00000000.*SPU Outbound Interrupt Mailbox.*0x00000000.*$gdb_prompt $"\
+      { pass "info spu mailbox" }
+  timeout { fail "(timeout) info spu mailbox" }
+}
 
 # 'info spu mailbox' should now contain data.
 c_to "Marker MboxEnd"