From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14451 invoked by alias); 18 Mar 2008 19:53:56 -0000 Received: (qmail 14433 invoked by uid 22791); 18 Mar 2008 19:53:55 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 18 Mar 2008 19:53:29 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id m2IJrQpk246020 for ; Tue, 18 Mar 2008 19:53:26 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m2IJrPxs1937428 for ; Tue, 18 Mar 2008 20:53:26 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m2IJrP0K005072 for ; Tue, 18 Mar 2008 20:53:25 +0100 Received: from bbkeks.de.ibm.com (dyn-9-152-248-39.boeblingen.de.ibm.com [9.152.248.39]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m2IJrOKn005067 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 18 Mar 2008 20:53:25 +0100 Message-ID: <47E01DB4.6030900@de.ibm.com> Date: Tue, 18 Mar 2008 19:53:00 -0000 From: Markus Deuling User-Agent: Thunderbird 2.0.0.12 (X11/20080213) MIME-Version: 1.0 To: GDB Patches CC: Ulrich Weigand Subject: Re: [rfc] Fix info spu mailbox command References: <200803171322.m2HDMfBG006655@d12av02.megacenter.de.ibm.com> In-Reply-To: <200803171322.m2HDMfBG006655@d12av02.megacenter.de.ibm.com> Content-Type: multipart/mixed; boundary="------------060809080606080603050102" Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-03/txt/msg00259.txt.bz2 This is a multi-part message in MIME format. --------------060809080606080603050102 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 404 Ulrich Weigand schrieb: > Markus Deuling: > >> * gdb.arch/spu-info.exp (info spu mailbox): Use correct initialisation >> value. > > This is OK. Even better would be to XFAIL (instead of FAIL) the new test > on old kernels ... > Hi Uli, now the test XFAILs on old kernels without Jeremy's patch. Ok ? -- Markus Deuling GNU Toolchain for Linux on Cell BE deuling@de.ibm.com --------------060809080606080603050102 Content-Type: text/plain; name="fix-spu-mailbox" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="fix-spu-mailbox" Content-length: 960 diff -urpN src/gdb/testsuite/gdb.arch/spu-info.exp dev/gdb/testsuite/gdb.arch/spu-info.exp --- src/gdb/testsuite/gdb.arch/spu-info.exp 2008-01-01 23:53:18.000000000 +0100 +++ dev/gdb/testsuite/gdb.arch/spu-info.exp 2008-03-17 15:56:55.000000000 +0100 @@ -200,9 +200,14 @@ gdb_test "finish" "" "finish" # Mailbox Test # 'info spu mailbox' should be empty. c_to "Marker Mbox" -gdb_test "info spu mailbox" \ - "SPU Outbound Mailbox.*0xc0000000.*SPU Outbound Interrupt Mailbox.*0xc0000000.*" \ - "info spu mailbox" +send_gdb "info spu mailbox\n" +gdb_expect { + -re "SPU Outbound Mailbox.*0xc0000000.*SPU Outbound Interrupt Mailbox.*0xc0000000.*$gdb_prompt $"\ + { xfail "info spu mailbox" } + -re "SPU Outbound Mailbox.*0x00000000.*SPU Outbound Interrupt Mailbox.*0x00000000.*$gdb_prompt $"\ + { pass "info spu mailbox" } + timeout { fail "(timeout) info spu mailbox" } +} # 'info spu mailbox' should now contain data. c_to "Marker MboxEnd" --------------060809080606080603050102--