Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Markus Deuling <deuling@de.ibm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>,
		Ulrich Weigand <uweigand@de.ibm.com>,
		Daniel Jacobowitz <drow@false.org>
Subject: Re: [rfc] Fix info spu mailbox command
Date: Wed, 19 Mar 2008 18:33:00 -0000	[thread overview]
Message-ID: <20080319183220.GA3588@adacore.com> (raw)
In-Reply-To: <47E154F5.10204@de.ibm.com>

Hi Markus,

> +set msg "info spu mailbox"
> +gdb_test_multiple "info spu mailbox " $msg {
> +  -re "SPU Outbound Mailbox.*0x00000000.*SPU Outbound Interrupt Mailbox.*0x00000000.*$gdb_prompt $" \
> +    { pass $msg }
> +  default {
> +    xfail $msg
> +  }
> +}

After having looked at your previous patch, it looks like you probably
wanted to only xfail the test when the 0x number (mailbox number?) is
0xc0000000, but anything else is an unexpected FAIL. Also, I don't think
you need the "default" block. So I think your test should look like this:

gdb_test_multiple "info spu mailbox" "$msg" {
    -re "SPU Outbound Mailbox.*0x00000000.*SPU Outbound Interrupt Mailbox.*0x00000000.*$gdb_prompt $" {
         pass "$msg"
    }
    -re "SPU Outbound Mailbox.*0xc0000000.*SPU Outbound Interrupt Mailbox.*0xc0000000.*$gdb_prompt $" {
         xfail "$msg"
    }
}

-- 
Joel


  reply	other threads:[~2008-03-19 18:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-14  6:27 Markus Deuling
2008-03-17 13:23 ` Ulrich Weigand
2008-03-18 19:53   ` Markus Deuling
2008-03-18 21:25     ` Joel Brobecker
2008-03-19 10:28       ` Markus Deuling
2008-03-19 11:54         ` Daniel Jacobowitz
2008-03-19 18:01           ` Markus Deuling
2008-03-19 18:33             ` Joel Brobecker [this message]
2008-03-19 18:50               ` Markus Deuling
2008-03-19 21:12                 ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080319183220.GA3588@adacore.com \
    --to=brobecker@adacore.com \
    --cc=deuling@de.ibm.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox