From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-54643-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 5428 invoked by alias); 19 Mar 2008 18:33:31 -0000
Received: (qmail 5414 invoked by uid 22791); 19 Mar 2008 18:33:30 -0000
X-Spam-Check-By: sourceware.org
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Mar 2008 18:33:08 +0000
Received: from localhost (localhost.localdomain [127.0.0.1]) 	by filtered-rock.gnat.com (Postfix) with ESMTP id ABC812A9960; 	Wed, 19 Mar 2008 14:32:22 -0400 (EDT)
Received: from rock.gnat.com ([127.0.0.1]) 	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) 	with LMTP id OJ7tagvvhHGZ; Wed, 19 Mar 2008 14:32:22 -0400 (EDT)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) 	by rock.gnat.com (Postfix) with ESMTP id 464682A9954; 	Wed, 19 Mar 2008 14:32:22 -0400 (EDT)
Received: by joel.gnat.com (Postfix, from userid 1000) 	id 26DA0E7ACB; Wed, 19 Mar 2008 11:32:20 -0700 (PDT)
Date: Wed, 19 Mar 2008 18:33:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Markus Deuling <deuling@de.ibm.com>
Cc: GDB Patches <gdb-patches@sourceware.org>, 	Ulrich Weigand <uweigand@de.ibm.com>, 	Daniel Jacobowitz <drow@false.org>
Subject: Re: [rfc] Fix info spu mailbox command
Message-ID: <20080319183220.GA3588@adacore.com>
References: <200803171322.m2HDMfBG006655@d12av02.megacenter.de.ibm.com> <47E01DB4.6030900@de.ibm.com> <20080318212521.GB3683@adacore.com> <47E0EAB3.5080703@de.ibm.com> <20080319115354.GA32034@caradoc.them.org> <47E154F5.10204@de.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <47E154F5.10204@de.ibm.com>
User-Agent: Mutt/1.4.2.2i
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-03/txt/msg00285.txt.bz2

Hi Markus,

> +set msg "info spu mailbox"
> +gdb_test_multiple "info spu mailbox " $msg {
> +  -re "SPU Outbound Mailbox.*0x00000000.*SPU Outbound Interrupt Mailbox.*0x00000000.*$gdb_prompt $" \
> +    { pass $msg }
> +  default {
> +    xfail $msg
> +  }
> +}

After having looked at your previous patch, it looks like you probably
wanted to only xfail the test when the 0x number (mailbox number?) is
0xc0000000, but anything else is an unexpected FAIL. Also, I don't think
you need the "default" block. So I think your test should look like this:

gdb_test_multiple "info spu mailbox" "$msg" {
    -re "SPU Outbound Mailbox.*0x00000000.*SPU Outbound Interrupt Mailbox.*0x00000000.*$gdb_prompt $" {
         pass "$msg"
    }
    -re "SPU Outbound Mailbox.*0xc0000000.*SPU Outbound Interrupt Mailbox.*0xc0000000.*$gdb_prompt $" {
         xfail "$msg"
    }
}

-- 
Joel