[gdbserver] (10/11) Don't report dll events on first attach when --attach'ing

[gdbserver] (10/11) Don't report dll events on first attach when --attach'ing

[Pedro Alves]

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

Hi,

When attaching to a process, we're reporting the loaded dlls on
the first target remote attach, thus gdb will print:

"Stopped due to shared library event"

This was already handled for the normal run case.  The patch
simple makes the fix unconditional.

Cheers,
Pedro Alves




[-- Attachment #2: gdbserver_attach_no_dllevent.diff --]
[-- Type: text/x-diff, Size: 1214 bytes --]

2007-11-12  Pedro Alves  <pedro_alves@portugalmail.pt>

	* server.c (main): Don't report dll events on the initial
	connection on attaches.

---
 gdb/gdbserver/server.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Index: src/gdb/gdbserver/server.c
===================================================================
--- src.orig/gdb/gdbserver/server.c	2007-11-11 23:16:20.000000000 +0000
+++ src/gdb/gdbserver/server.c	2007-11-11 23:16:30.000000000 +0000
@@ -903,10 +903,6 @@ main (int argc, char *argv[])
       /* We are now (hopefully) stopped at the first instruction of
 	 the target process.  This assumes that the target process was
 	 successfully created.  */
-
-      /* Don't report shared library events on the initial connection,
-	 even if some libraries are preloaded.  */
-      dlls_changed = 0;
     }
   else
     {
@@ -921,6 +917,11 @@ main (int argc, char *argv[])
 	}
     }
 
+  /* Don't report shared library events on the initial connection,
+     even if some libraries are preloaded.  Avoids the "stopped by
+     shared library event" notice on gdb side.  */
+  dlls_changed = 0;
+
   if (setjmp (toplevel))
     {
       fprintf (stderr, "Killing inferior\n");

Re: [gdbserver] (10/11) Don't report dll events on first attach when --attach'ing

[Daniel Jacobowitz]

On Mon, Nov 12, 2007 at 02:08:55AM +0000, Pedro Alves wrote:
> 2007-11-12  Pedro Alves  <pedro_alves@portugalmail.pt>
> 
> 	* server.c (main): Don't report dll events on the initial
> 	connection on attaches.

OK.

-- 
Daniel Jacobowitz
CodeSourcery

Re: [gdbserver] (10/11) Don't report dll events on first attach when --attach'ing

[Pedro Alves]

Daniel Jacobowitz wrote:
> On Mon, Nov 12, 2007 at 02:08:55AM +0000, Pedro Alves wrote:
>> 2007-11-12  Pedro Alves  <pedro_alves@portugalmail.pt>
>>
>> 	* server.c (main): Don't report dll events on the initial
>> 	connection on attaches.
> 
> OK.
> 

Thanks, checked in.

-- 
Pedro Alves