Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro_alves@portugalmail.pt>
To: gdb-patches@sourceware.org, Lerele <lerele@champenstudios.com>
Subject: [gdbserver] (10/11) Don't report dll events on first attach when  --attach'ing
Date: Mon, 12 Nov 2007 02:08:00 -0000	[thread overview]
Message-ID: <4737B5B7.4080902@portugalmail.pt> (raw)

[-- Attachment #1: Type: text/plain, Size: 283 bytes --]

Hi,

When attaching to a process, we're reporting the loaded dlls on
the first target remote attach, thus gdb will print:

"Stopped due to shared library event"

This was already handled for the normal run case.  The patch
simple makes the fix unconditional.

Cheers,
Pedro Alves




[-- Attachment #2: gdbserver_attach_no_dllevent.diff --]
[-- Type: text/x-diff, Size: 1214 bytes --]

2007-11-12  Pedro Alves  <pedro_alves@portugalmail.pt>

	* server.c (main): Don't report dll events on the initial
	connection on attaches.

---
 gdb/gdbserver/server.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Index: src/gdb/gdbserver/server.c
===================================================================
--- src.orig/gdb/gdbserver/server.c	2007-11-11 23:16:20.000000000 +0000
+++ src/gdb/gdbserver/server.c	2007-11-11 23:16:30.000000000 +0000
@@ -903,10 +903,6 @@ main (int argc, char *argv[])
       /* We are now (hopefully) stopped at the first instruction of
 	 the target process.  This assumes that the target process was
 	 successfully created.  */
-
-      /* Don't report shared library events on the initial connection,
-	 even if some libraries are preloaded.  */
-      dlls_changed = 0;
     }
   else
     {
@@ -921,6 +917,11 @@ main (int argc, char *argv[])
 	}
     }
 
+  /* Don't report shared library events on the initial connection,
+     even if some libraries are preloaded.  Avoids the "stopped by
+     shared library event" notice on gdb side.  */
+  dlls_changed = 0;
+
   if (setjmp (toplevel))
     {
       fprintf (stderr, "Killing inferior\n");



             reply	other threads:[~2007-11-12  2:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-12  2:08 Pedro Alves [this message]
2007-12-01 19:02 ` Daniel Jacobowitz
2007-12-03  3:54   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4737B5B7.4080902@portugalmail.pt \
    --to=pedro_alves@portugalmail.pt \
    --cc=gdb-patches@sourceware.org \
    --cc=lerele@champenstudios.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox