Patch: Remove STOP_UNKNOWN/BREAKPOINT_HIT from infrun.c

Patch: Remove STOP_UNKNOWN/BREAKPOINT_HIT from infrun.c

[Markus Deuling]

Hi,

> Sorry, I missed this message.  I think we can remove both of them.

as discussed this patch removes STOP_UNKNOWN and BREAKPOINT_HIT from infrun.c


Ok to commit?


ChangeLog:

      * infrun.c (inferior_stop_reason, print_stop_reason): Remove
      BREAKPOINT_HIT and STOP_UNKNOWN.

Regards,
Markus

-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com 

=========================================

diff -urN src/gdb/infrun.c dev/gdb/infrun.c
--- src/gdb/infrun.c    2007-01-10 21:10:23.000000000 +0100
+++ dev/gdb/infrun.c    2007-02-22 15:23:34.000000000 +0100
@@ -904,12 +904,8 @@
  to the interface from within handle_inferior_event(). */
enum inferior_stop_reason
{
-  /* We don't know why. */
-  STOP_UNKNOWN,
 /* Step, next, nexti, stepi finished. */
 END_STEPPING_RANGE,
-  /* Found breakpoint. */
-  BREAKPOINT_HIT,
 /* Inferior terminated by signal. */
 SIGNAL_EXITED,
 /* Inferior exited. */
@@ -2986,10 +2982,6 @@
{
 switch (stop_reason)
   {
-    case STOP_UNKNOWN:
-      /* We don't deal with these cases from handle_inferior_event()
-         yet. */
-      break;
   case END_STEPPING_RANGE:
     /* We are done with a step/next/si/ni command. */
     /* For now print nothing. */
@@ -3001,10 +2993,6 @@
          (uiout, "reason",
           async_reason_lookup (EXEC_ASYNC_END_STEPPING_RANGE));
     break;
-    case BREAKPOINT_HIT:
-      /* We found a breakpoint. */
-      /* For now print nothing. */
-      break;
   case SIGNAL_EXITED:
     /* The inferior was terminated by a signal. */
     annotate_signalled ();

Re: Patch: Remove STOP_UNKNOWN/BREAKPOINT_HIT from infrun.c

[Daniel Jacobowitz]

On Thu, Feb 22, 2007 at 03:33:08PM +0100, Markus Deuling wrote:
> Hi,
> 
> >Sorry, I missed this message.  I think we can remove both of them.
> 
> as discussed this patch removes STOP_UNKNOWN and BREAKPOINT_HIT from 
> infrun.c
> 
> 
> Ok to commit?

I really need for you to find a way to post patches as text, that
doesn't get mangled by your mail client:

> enum inferior_stop_reason
> {
> -  /* We don't know why. */
> -  STOP_UNKNOWN,
> /* Step, next, nexti, stepi finished. */
> END_STEPPING_RANGE,

It's very hard to read these.

-- 
Daniel Jacobowitz
CodeSourcery

Patch: Remove STOP_UNKNOWN/BREAKPOINT_HIT from infrun.c

[Markus Deuling]

[-- Attachment #1: Type: text/plain, Size: 483 bytes --]

Hi,

sorry for the mangled patch. From now on I attach the patches. I give up to configure
Thunderbird :-(

> Sorry, I missed this message.  I think we can remove both of them.

As discussed this patch removes STOP_UNKNOWN and BREAKPOINT_HIT from infrun.c


Ok to commit?


ChangeLog:

     * infrun.c (inferior_stop_reason, print_stop_reason): Remove
     BREAKPOINT_HIT and STOP_UNKNOWN.

Regards,
Markus

-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com 


[-- Attachment #2: diff-cleanup-infrun --]
[-- Type: text/plain, Size: 1162 bytes --]

diff -urN src/gdb/infrun.c dev/gdb/infrun.c
--- src/gdb/infrun.c	2007-01-10 21:10:23.000000000 +0100
+++ dev/gdb/infrun.c	2007-02-22 15:23:34.000000000 +0100
@@ -904,12 +904,8 @@
    to the interface from within handle_inferior_event(). */
 enum inferior_stop_reason
 {
-  /* We don't know why. */
-  STOP_UNKNOWN,
   /* Step, next, nexti, stepi finished. */
   END_STEPPING_RANGE,
-  /* Found breakpoint. */
-  BREAKPOINT_HIT,
   /* Inferior terminated by signal. */
   SIGNAL_EXITED,
   /* Inferior exited. */
@@ -2986,10 +2982,6 @@
 {
   switch (stop_reason)
     {
-    case STOP_UNKNOWN:
-      /* We don't deal with these cases from handle_inferior_event()
-         yet. */
-      break;
     case END_STEPPING_RANGE:
       /* We are done with a step/next/si/ni command. */
       /* For now print nothing. */
@@ -3001,10 +2993,6 @@
 	    (uiout, "reason",
 	     async_reason_lookup (EXEC_ASYNC_END_STEPPING_RANGE));
       break;
-    case BREAKPOINT_HIT:
-      /* We found a breakpoint. */
-      /* For now print nothing. */
-      break;
     case SIGNAL_EXITED:
       /* The inferior was terminated by a signal. */
       annotate_signalled ();

Re: Patch: Remove STOP_UNKNOWN/BREAKPOINT_HIT from infrun.c

[Daniel Jacobowitz]

On Thu, Feb 22, 2007 at 03:51:00PM +0100, Markus Deuling wrote:
> Ok to commit?
> 
> 
> ChangeLog:
> 
>     * infrun.c (inferior_stop_reason, print_stop_reason): Remove
>     BREAKPOINT_HIT and STOP_UNKNOWN.

OK, thanks.

-- 
Daniel Jacobowitz
CodeSourcery

Re: Patch: Remove STOP_UNKNOWN/BREAKPOINT_HIT from infrun.c

[Ulrich Weigand]

Daniel Jakobowitz wrote:
> On Thu, Feb 22, 2007 at 03:51:00PM +0100, Markus Deuling wrote:
> > Ok to commit?
> > 
> > 
> > ChangeLog:
> > 
> >     * infrun.c (inferior_stop_reason, print_stop_reason): Remove
> >     BREAKPOINT_HIT and STOP_UNKNOWN.
> 
> OK, thanks.

I've checked this in, thanks.

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com