Compilation error, expat version too old.

Compilation error, expat version too old.

[Denis PILAT]

Hello,

I am facing compilation error with xml-support.c, it comes from the 
expat version I have, it should be too old to define XMLCALL I guess.
Bellow is the the error.
Shouldn't we provide expat required version with gdb distribution ?

-- 
Denis

gcc -c -g -O2 -I. 
-I/project/flexdbug/user/pd10/gdb/sts-gdb-repository/vendor/cvs/head/src/gdb 
-I/project/flexdbug/user/pd10/gdb/sts-gdb-repository/vendor/cvs/head/src/gdb/config 
-DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H 
-I/project/flexdbug/user/pd10/gdb/sts-gdb-repository/vendor/cvs/head/src/gdb/../include/opcode 
-I/project/flexdbug/user/pd10/gdb/sts-gdb-repository/vendor/cvs/head/src/gdb/../readline/.. 
-I../bfd 
-I/project/flexdbug/user/pd10/gdb/sts-gdb-repository/vendor/cvs/head/src/gdb/../bfd 
-I/project/flexdbug/user/pd10/gdb/sts-gdb-repository/vendor/cvs/head/src/gdb/../include 
-DMI_OUT=1 -DTUI=1 -Wall -Wdeclaration-after-statement -Wpointer-arith 
-Wformat-nonliteral -Wno-pointer-sign -Wno-unused -Wno-switch -Werror 
/project/flexdbug/user/pd10/gdb/sts-gdb-repository/vendor/cvs/head/src/gdb/xml-support.c
/project/flexdbug/user/pd10/gdb/sts-gdb-repository/vendor/cvs/head/src/gdb/xml-support.c:473: 
error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before 
‘gdb_xml_fetch_external_entity
/project/flexdbug/user/pd10/gdb/sts-gdb-repository/vendor/cvs/head/src/gdb/xml-support.c: 
In function ‘gdb_xml_use_dtd’:
/project/flexdbug/user/pd10/gdb/sts-gdb-repository/vendor/cvs/head/src/gdb/xml-support.c:527: 
error: ‘gdb_xml_fetch_external_entity’ undeclared (first use in this 
function)
/project/flexdbug/user/pd10/gdb/sts-gdb-repository/vendor/cvs/head/src/gdb/xml-support.c:527: 
error: (Each undeclared identifier is reported only once

Re: Compilation error, expat version too old.

[Daniel Jacobowitz]

On Mon, Feb 12, 2007 at 11:10:31AM +0100, Denis PILAT wrote:
> Hello,
> 
> I am facing compilation error with xml-support.c, it comes from the 
> expat version I have, it should be too old to define XMLCALL I guess.
> Bellow is the the error.

What version of expat is it?  We should either update the configure
check to reject it, or provide a fallback definition of XMLCALL.

> Shouldn't we provide expat required version with gdb distribution ?

We decided not to do that for various reasons.

-- 
Daniel Jacobowitz
CodeSourcery

Re: Compilation error, expat version too old.

[Denis PILAT]

Daniel Jacobowitz wrote:
> On Mon, Feb 12, 2007 at 04:38:13PM +0100, Denis PILAT wrote:
>   
>> Daniel Jacobowitz wrote:
>>     
>>> On Mon, Feb 12, 2007 at 11:10:31AM +0100, Denis PILAT wrote:
>>>  
>>>       
>>>> Hello,
>>>>
>>>> I am facing compilation error with xml-support.c, it comes from the 
>>>> expat version I have, it should be too old to define XMLCALL I guess.
>>>> Bellow is the the error.
>>>>    
>>>>         
>>> What version of expat is it?  We should either update the configure
>>> check to reject it, or provide a fallback definition of XMLCALL.
>>>  
>>>       
>> I have "expat-1.95.5-6".
>> (I know it's a prehistoric version, but I guess I'm not the only one 
>> working in the 20ieth century ...;-)
>>     
>
> Yep:
>
> Release 1.95.7 Mon Oct 20 2003
>
>         - Introduced an XMLCALL macro to control the calling
>           convention used by the Expat API; this macro should be used
>           to annotate prototypes and definitions of callback
>           implementations in code compiled with a calling convention
>           other than the default convention for the host platform.
>
> We could provide a default definition of XMLCALL in gdb_expat.h,
> to empty.  Does that work?
>
>   
Yes it works with that.

Here is the proposed patch

-- 
Denis

2007-02-13  Denis Pilat  <denis.pilat@st.com>

	* gdb_expat.h (XMLCALL): Defined.

Index: gdb_expat.h
===================================================================
RCS file: /cvs/src/src/gdb/gdb_expat.h,v
retrieving revision 1.2
diff -u -p -r1.2 gdb_expat.h
--- gdb_expat.h	9 Jan 2007 17:58:50 -0000	1.2
+++ gdb_expat.h	13 Feb 2007 09:47:21 -0000
@@ -31,4 +31,10 @@
 # define XML_STATUS_ERROR 0
 #endif
 
+/* Provide an empty definition of XMLCALL since it is defined only from
+   version 1.95.7 of Expat.  */
+#ifndef XMLCALL
+# define XMLCALL
+#endif
+
 #endif /* !defined(GDB_EXPAT_H) */

Re: Compilation error, expat version too old.

[Daniel Jacobowitz]

On Tue, Feb 13, 2007 at 10:52:35AM +0100, Denis PILAT wrote:
> 2007-02-13  Denis Pilat  <denis.pilat@st.com>
> 
> 	* gdb_expat.h (XMLCALL): Defined.

Sorry I hadn't gotten back to you about this yet!  Joel's fixed it
meanwhile.

-- 
Daniel Jacobowitz
CodeSourcery