From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19506 invoked by alias); 13 Feb 2007 09:52:52 -0000 Received: (qmail 19497 invoked by uid 22791); 13 Feb 2007 09:52:52 -0000 X-Spam-Check-By: sourceware.org Received: from vir-del-04.spheriq.net (HELO vir-del-04.spheriq.net) (194.50.41.43) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 13 Feb 2007 09:52:43 +0000 Received: from vir-out-02.spheriq.net ([194.50.41.31]) by vir-del-04.spheriq.net with ESMTP id l1D9qfuv032677 for ; Tue, 13 Feb 2007 09:52:41 GMT Received: from vir-cus-01.spheriq.net (vir-cus-01.spheriq.net [194.50.41.85]) by vir-out-02.spheriq.net with ESMTP id l1D9qdnL012605 for ; Tue, 13 Feb 2007 09:52:40 GMT Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by vir-cus-01.spheriq.net with ESMTP id l1D9qbWT032716 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 13 Feb 2007 09:52:39 GMT Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 783D3DA49; Tue, 13 Feb 2007 09:52:36 +0000 (GMT) Received: from mail1.cro.st.com (mail1.cro.st.com [164.129.40.131]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 4231C472D5; Tue, 13 Feb 2007 09:52:36 +0000 (GMT) Received: from [164.129.44.95] (crx595.cro.st.com [164.129.44.95]) by mail1.cro.st.com (MOS 3.7.5a-GA) with ESMTP id CJS51772 (AUTH "denis pilat"); Tue, 13 Feb 2007 10:52:35 +0100 (CET) Message-ID: <45D18A63.8040506@st.com> Date: Tue, 13 Feb 2007 09:52:00 -0000 From: Denis PILAT User-Agent: Thunderbird 1.5.0.9 (X11/20061206) MIME-Version: 1.0 To: Daniel Jacobowitz , gdb-patches Subject: Re: Compilation error, expat version too old. References: <45D03D17.1070907@st.com> <20070212151109.GA1336@caradoc.them.org> <45D089E5.8040900@st.com> <20070212205100.GA28635@caradoc.them.org> In-Reply-To: <20070212205100.GA28635@caradoc.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00178.txt.bz2 Daniel Jacobowitz wrote: > On Mon, Feb 12, 2007 at 04:38:13PM +0100, Denis PILAT wrote: > >> Daniel Jacobowitz wrote: >> >>> On Mon, Feb 12, 2007 at 11:10:31AM +0100, Denis PILAT wrote: >>> >>> >>>> Hello, >>>> >>>> I am facing compilation error with xml-support.c, it comes from the >>>> expat version I have, it should be too old to define XMLCALL I guess. >>>> Bellow is the the error. >>>> >>>> >>> What version of expat is it? We should either update the configure >>> check to reject it, or provide a fallback definition of XMLCALL. >>> >>> >> I have "expat-1.95.5-6". >> (I know it's a prehistoric version, but I guess I'm not the only one >> working in the 20ieth century ...;-) >> > > Yep: > > Release 1.95.7 Mon Oct 20 2003 > > - Introduced an XMLCALL macro to control the calling > convention used by the Expat API; this macro should be used > to annotate prototypes and definitions of callback > implementations in code compiled with a calling convention > other than the default convention for the host platform. > > We could provide a default definition of XMLCALL in gdb_expat.h, > to empty. Does that work? > > Yes it works with that. Here is the proposed patch -- Denis 2007-02-13 Denis Pilat * gdb_expat.h (XMLCALL): Defined. Index: gdb_expat.h =================================================================== RCS file: /cvs/src/src/gdb/gdb_expat.h,v retrieving revision 1.2 diff -u -p -r1.2 gdb_expat.h --- gdb_expat.h 9 Jan 2007 17:58:50 -0000 1.2 +++ gdb_expat.h 13 Feb 2007 09:47:21 -0000 @@ -31,4 +31,10 @@ # define XML_STATUS_ERROR 0 #endif +/* Provide an empty definition of XMLCALL since it is defined only from + version 1.95.7 of Expat. */ +#ifndef XMLCALL +# define XMLCALL +#endif + #endif /* !defined(GDB_EXPAT_H) */