Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro_alves@portugalmail.pt>
To: Pedro Alves <pedro_alves@portugalmail.pt>,   gdb-patches@sourceware.org
Subject: Re: [PATCH] A few Cygwin testsuite fixes.
Date: Mon, 18 Dec 2006 14:06:00 -0000	[thread overview]
Message-ID: <4586A057.5090507@portugalmail.pt> (raw)
In-Reply-To: <20061216213031.GA22650@nevyn.them.org>

Daniel Jacobowitz escreveu:
> On Sun, Dec 10, 2006 at 06:01:39PM +0000, Pedro Alves wrote:
>> Christopher Faylor escreveu:
>>> On Sun, Dec 10, 2006 at 01:43:03PM +0000, Pedro Alves wrote:
>>>
>>> I don't have the right to approve or commit this but I have to say that
>>> while the logic looks ok, I don't think the name of the variable you're
>>> using should be "DLLEXT".  A "DLL" is generally a windows thing.  Maybe
>>> it should be SOEXT instead.
>> Thanks for taking a look.  I had considered both, but, in the end I sticked
>> with DLLEXT, because I felt that the 'dynamic' in DLL goes more to the 
>> point, than
>> 'shared' in SO goes.  I can change that, no prob.
>>
>> Attached is the updated/renamed patch.
>>
>> Please review and commit.
> 
> Hi Pedro,
> 
> Do you want to go ahead with this or drop the $SOEXT portions (after
> your ld patch)?
> 

Sorry I didn't say anything here.

Well, after the ld patch is applied, there is no need for this for
Cygwin/MinGW/arm-wince anymore, so I am OK with dropping it.

Thanks,

Cheers,
Pedro Alves


      reply	other threads:[~2006-12-18 14:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-10 13:43 Pedro Alves
2006-12-10 17:33 ` Christopher Faylor
2006-12-10 18:02   ` Pedro Alves
2006-12-16 21:30     ` Daniel Jacobowitz
2006-12-18 14:06       ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4586A057.5090507@portugalmail.pt \
    --to=pedro_alves@portugalmail.pt \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox