From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14928 invoked by alias); 18 Dec 2006 14:06:45 -0000 Received: (qmail 14898 invoked from network); 18 Dec 2006 14:06:32 -0000 Received: from unknown (195.23.133.215) by sourceware.org with QMTP; 18 Dec 2006 14:06:32 -0000 Received: (qmail 6903 invoked from network); 18 Dec 2006 14:06:31 -0000 Received: from unknown (HELO mailfrt06.isp.novis.pt) ([195.23.133.198]) (envelope-sender ) by mailrly05.isp.novis.pt with compressed SMTP; 18 Dec 2006 14:06:31 -0000 Received: (qmail 5198 invoked from network); 18 Dec 2006 14:06:26 -0000 Received: from unknown (HELO [127.0.0.1]) ([195.23.225.137]) (envelope-sender ) by mailfrt06.isp.novis.pt with SMTP; 18 Dec 2006 14:06:26 -0000 Message-ID: <4586A057.5090507@portugalmail.pt> Date: Mon, 18 Dec 2006 14:06:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-BR; rv:1.8.0.8) Gecko/20061025 Thunderbird/1.5.0.8 Mnenhy/0.7.4.0 MIME-Version: 1.0 To: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH] A few Cygwin testsuite fixes. References: <457C0EE7.1010306@portugalmail.pt> <20061210173253.GA21807@trixie.casa.cgf.cx> <457C4B83.4010205@portugalmail.pt> <20061216213031.GA22650@nevyn.them.org> In-Reply-To: <20061216213031.GA22650@nevyn.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 0659-1, 16-12-2006), Outbound message X-Antivirus-Status: Clean X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00241.txt.bz2 Daniel Jacobowitz escreveu: > On Sun, Dec 10, 2006 at 06:01:39PM +0000, Pedro Alves wrote: >> Christopher Faylor escreveu: >>> On Sun, Dec 10, 2006 at 01:43:03PM +0000, Pedro Alves wrote: >>> >>> I don't have the right to approve or commit this but I have to say that >>> while the logic looks ok, I don't think the name of the variable you're >>> using should be "DLLEXT". A "DLL" is generally a windows thing. Maybe >>> it should be SOEXT instead. >> Thanks for taking a look. I had considered both, but, in the end I sticked >> with DLLEXT, because I felt that the 'dynamic' in DLL goes more to the >> point, than >> 'shared' in SO goes. I can change that, no prob. >> >> Attached is the updated/renamed patch. >> >> Please review and commit. > > Hi Pedro, > > Do you want to go ahead with this or drop the $SOEXT portions (after > your ld patch)? > Sorry I didn't say anything here. Well, after the ld patch is applied, there is no need for this for Cygwin/MinGW/arm-wince anymore, so I am OK with dropping it. Thanks, Cheers, Pedro Alves