From: Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>
To: Pedro Alves <pedro_alves@portugalmail.pt>, gdb-patches@sourceware.org
Subject: Re: [PATCH] A few Cygwin testsuite fixes.
Date: Sun, 10 Dec 2006 17:33:00 -0000 [thread overview]
Message-ID: <20061210173253.GA21807@trixie.casa.cgf.cx> (raw)
In-Reply-To: <457C0EE7.1010306@portugalmail.pt>
On Sun, Dec 10, 2006 at 01:43:03PM +0000, Pedro Alves wrote:
>Hi all,
>
>This patch fixes a few fails on i686-pc-cygwin.
>- It adds a few missing $EXEEXT.
>- Adds a new $DLLEXT variable for the dynamic library tests and uses it.
>
>Please review and commit.
I don't have the right to approve or commit this but I have to say that
while the logic looks ok, I don't think the name of the variable you're
using should be "DLLEXT". A "DLL" is generally a windows thing. Maybe
it should be SOEXT instead.
cgf
next prev parent reply other threads:[~2006-12-10 17:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-10 13:43 Pedro Alves
2006-12-10 17:33 ` Christopher Faylor [this message]
2006-12-10 18:02 ` Pedro Alves
2006-12-16 21:30 ` Daniel Jacobowitz
2006-12-18 14:06 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061210173253.GA21807@trixie.casa.cgf.cx \
--to=cgf-use-the-mailinglist-please@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro_alves@portugalmail.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox