From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14689 invoked by alias); 10 Dec 2006 17:33:01 -0000 Received: (qmail 14681 invoked by uid 22791); 10 Dec 2006 17:33:00 -0000 X-Spam-Check-By: sourceware.org Received: from pool-71-248-179-54.bstnma.fios.verizon.net (HELO cgf.cx) (71.248.179.54) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 10 Dec 2006 17:32:56 +0000 Received: by cgf.cx (Postfix, from userid 201) id 13BB913D1CD; Sun, 10 Dec 2006 12:32:54 -0500 (EST) Date: Sun, 10 Dec 2006 17:33:00 -0000 From: Christopher Faylor To: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH] A few Cygwin testsuite fixes. Message-ID: <20061210173253.GA21807@trixie.casa.cgf.cx> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org References: <457C0EE7.1010306@portugalmail.pt> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <457C0EE7.1010306@portugalmail.pt> User-Agent: Mutt/1.5.11 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00155.txt.bz2 On Sun, Dec 10, 2006 at 01:43:03PM +0000, Pedro Alves wrote: >Hi all, > >This patch fixes a few fails on i686-pc-cygwin. >- It adds a few missing $EXEEXT. >- Adds a new $DLLEXT variable for the dynamic library tests and uses it. > >Please review and commit. I don't have the right to approve or commit this but I have to say that while the logic looks ok, I don't think the name of the variable you're using should be "DLLEXT". A "DLL" is generally a windows thing. Maybe it should be SOEXT instead. cgf