* psim stfiwx instruction patch
@ 2006-12-12 12:31 Joel Sherrill
2006-12-12 13:50 ` Tom Marn
2006-12-12 14:40 ` Daniel Jacobowitz
0 siblings, 2 replies; 4+ messages in thread
From: Joel Sherrill @ 2006-12-12 12:31 UTC (permalink / raw)
To: Tom Marn, Daniel Jacobowitz, gdb-patches
Hi,
This is in reference to the patch in:
http://sources.redhat.com/ml/gdb-patches/2006-11/msg00243.html
and your comments here:
http://sources.redhat.com/ml/gdb-patches/2006-11/msg00315.html
I don't have a whole lot to offer except that gcc now generates
this instruction and the simulator needs it. The RTEMS test code
which made gcc generate this instruction now run correctly. Those
tests are not specifically of this instruction by itself but of an
entire program where gcc generated it.
So things are better with this patch than without. Without,
you get an exception and die. With it, you run.
If the comments stay, is the patch OK?
--joel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: psim stfiwx instruction patch
2006-12-12 12:31 psim stfiwx instruction patch Joel Sherrill
@ 2006-12-12 13:50 ` Tom Marn
2006-12-12 14:40 ` Daniel Jacobowitz
1 sibling, 0 replies; 4+ messages in thread
From: Tom Marn @ 2006-12-12 13:50 UTC (permalink / raw)
To: Joel Sherrill; +Cc: gdb-patches, Daniel Jacobowitz
Joel Sherrill wrote:
>
> Hi,
>
> This is in reference to the patch in:
>
> http://sources.redhat.com/ml/gdb-patches/2006-11/msg00243.html
>
> and your comments here:
>
> http://sources.redhat.com/ml/gdb-patches/2006-11/msg00315.html
>
> I don't have a whole lot to offer except that gcc now generates
> this instruction and the simulator needs it. The RTEMS test code
> which made gcc generate this instruction now run correctly. Those
> tests are not specifically of this instruction by itself but of an
> entire program where gcc generated it.
>
> So things are better with this patch than without. Without,
> you get an exception and die. With it, you run.
>
> If the comments stay, is the patch OK?
No, on comment out location GDB code just won't compile.
But at new (for me ;) ) more appropriate location compiles without problems.
See my comment: http://sources.redhat.com/ml/gdb-patches/2006-11/msg00370.html
Tom
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: psim stfiwx instruction patch
2006-12-12 12:31 psim stfiwx instruction patch Joel Sherrill
2006-12-12 13:50 ` Tom Marn
@ 2006-12-12 14:40 ` Daniel Jacobowitz
2006-12-12 15:38 ` Joel Sherrill
1 sibling, 1 reply; 4+ messages in thread
From: Daniel Jacobowitz @ 2006-12-12 14:40 UTC (permalink / raw)
To: Joel Sherrill; +Cc: Tom Marn, gdb-patches
On Tue, Dec 12, 2006 at 06:31:12AM -0600, Joel Sherrill wrote:
> If the comments stay, is the patch OK?
Isn't it already committed?
--
Daniel Jacobowitz
CodeSourcery
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: psim stfiwx instruction patch
2006-12-12 14:40 ` Daniel Jacobowitz
@ 2006-12-12 15:38 ` Joel Sherrill
0 siblings, 0 replies; 4+ messages in thread
From: Joel Sherrill @ 2006-12-12 15:38 UTC (permalink / raw)
To: Joel Sherrill, Tom Marn, gdb-patches
Daniel Jacobowitz wrote:
> On Tue, Dec 12, 2006 at 06:31:12AM -0600, Joel Sherrill wrote:
>
>> If the comments stay, is the patch OK?
>>
>
> Isn't it already committed?
>
>
Yes... sorry. I was checking up on the patch and didn't
see that it was already committed.
At least it is noted now that it works and if Andrew
committed it, then someone knowledgeable looked at it. :)
--joel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-12-12 15:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-12-12 12:31 psim stfiwx instruction patch Joel Sherrill
2006-12-12 13:50 ` Tom Marn
2006-12-12 14:40 ` Daniel Jacobowitz
2006-12-12 15:38 ` Joel Sherrill
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox