From: Tom Marn <tom.marn@telargo.com>
To: Joel Sherrill <joel.sherrill@oarcorp.com>
Cc: gdb-patches@sourceware.org, Daniel Jacobowitz <drow@false.org>
Subject: Re: psim stfiwx instruction patch
Date: Tue, 12 Dec 2006 13:50:00 -0000 [thread overview]
Message-ID: <457EB381.2090207@telargo.com> (raw)
In-Reply-To: <457EA110.7030302@oarcorp.com>
Joel Sherrill wrote:
>
> Hi,
>
> This is in reference to the patch in:
>
> http://sources.redhat.com/ml/gdb-patches/2006-11/msg00243.html
>
> and your comments here:
>
> http://sources.redhat.com/ml/gdb-patches/2006-11/msg00315.html
>
> I don't have a whole lot to offer except that gcc now generates
> this instruction and the simulator needs it. The RTEMS test code
> which made gcc generate this instruction now run correctly. Those
> tests are not specifically of this instruction by itself but of an
> entire program where gcc generated it.
>
> So things are better with this patch than without. Without,
> you get an exception and die. With it, you run.
>
> If the comments stay, is the patch OK?
No, on comment out location GDB code just won't compile.
But at new (for me ;) ) more appropriate location compiles without problems.
See my comment: http://sources.redhat.com/ml/gdb-patches/2006-11/msg00370.html
Tom
next prev parent reply other threads:[~2006-12-12 13:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-12 12:31 Joel Sherrill
2006-12-12 13:50 ` Tom Marn [this message]
2006-12-12 14:40 ` Daniel Jacobowitz
2006-12-12 15:38 ` Joel Sherrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457EB381.2090207@telargo.com \
--to=tom.marn@telargo.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=joel.sherrill@oarcorp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox