From: Chet Ramey <chet.ramey@case.edu>
To: Ulrich Weigand <uweigand@de.ibm.com>, gdb-patches@sourceware.org
Cc: chet@case.edu
Subject: Re: [PATCH] Readline bug causes GDB crash on 64-bit
Date: Sat, 21 Oct 2006 02:56:00 -0000 [thread overview]
Message-ID: <45398C0C.9090202@case.edu> (raw)
In-Reply-To: <20061020213228.GA14966@nevyn.them.org>
Daniel Jacobowitz wrote:
> On Fri, Oct 20, 2006 at 11:10:43PM +0200, Ulrich Weigand wrote:
>> Hello,
>>
>> GDB on s390x (64-bit) is crashing when you press ctrl-V.
>> This is because xmalloc is used without prototype in scope
>> in _rl_callback_data_alloc (readline/callback.c), and thus
>> the returned pointer is improperly truncated/extended.
>>
>> Fixed by including "xmalloc.h". Tested on s390x-ibm-linux.
>>
>> What's the policy for readline bugs in GDB? It is OK to check
>> this patch into GDB, or does it have to go upstream first?
>> (Where is readline upstream?)
>
> The right thing to do is to send the patch to Chet, and if he accepts
> it for the next readline release, commit it to our copy. I believe
> bash-maintainers@gnu.org (CC'd) is the right place.
Either that address or bug-readline@gnu.org will work. But in this
case, someone beat you to it, and the fix is in the recently-released
readline-5.2.
Chet
--
``The lyf so short, the craft so long to lerne.'' - Chaucer
Live Strong. No day but today.
Chet Ramey, ITS, CWRU chet@case.edu http://cnswww.cns.cwru.edu/~chet/
next prev parent reply other threads:[~2006-10-21 2:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-20 21:10 Ulrich Weigand
2006-10-20 21:30 ` Andreas Schwab
2006-10-20 21:36 ` Daniel Jacobowitz
2006-10-20 21:32 ` Daniel Jacobowitz
2006-10-21 2:56 ` Chet Ramey [this message]
2006-10-21 5:15 ` Daniel Jacobowitz
2006-10-21 20:48 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45398C0C.9090202@case.edu \
--to=chet.ramey@case.edu \
--cc=chet@case.edu \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox